Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 10409013: Only install the API level needed. (Closed)

Created:
8 years, 7 months ago by michaelbai
Modified:
8 years, 6 months ago
CC:
chromium-reviews, Wei James(wistoch)
Visibility:
Public.

Description

Only install the API level needed. Previously all API levels were installed, it wasted time especially when network conditon is poor. This change will only install the API level specified in SDK_TARGET_ID. BUG= TEST=Tested manually. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=139845

Patch Set 1 #

Patch Set 2 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/install-build-deps-android-sdk.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
michaelbai
8 years, 7 months ago (2012-05-17 22:23:17 UTC) #1
michaelbai
8 years, 7 months ago (2012-05-21 18:45:31 UTC) #2
Yaron
lgtm
8 years, 7 months ago (2012-05-21 20:58:40 UTC) #3
Yaron
Actually, can you make it install the current sdk and any newer ones? I'm curious ...
8 years, 7 months ago (2012-05-21 20:59:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelbai@chromium.org/10409013/1
8 years, 7 months ago (2012-05-21 21:09:35 UTC) #5
commit-bot: I haz the power
Try job failure for 10409013-1 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 7 months ago (2012-05-21 22:52:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelbai@chromium.org/10409013/13001
8 years, 7 months ago (2012-05-22 17:45:21 UTC) #7
commit-bot: I haz the power
Try job failure for 10409013-13001 (retry) on win_rel for steps "base_unittests, sync_unit_tests" (clobber build). It's ...
8 years, 7 months ago (2012-05-22 23:11:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelbai@chromium.org/10409013/13001
8 years, 6 months ago (2012-05-31 17:30:25 UTC) #9
commit-bot: I haz the power
8 years, 6 months ago (2012-05-31 20:06:34 UTC) #10
Change committed as 139845

Powered by Google App Engine
This is Rietveld 408576698