Issue 10409011: Aura/ash: On Desktops, use a aura::client to resolve screen coordinates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10409011: Aura/ash: On Desktops, use a aura::client to resolve screen coordinates. (Closed)

Created:
8 years, 7 months ago by Elliot Glaysher

Modified:
8 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, ben+watch_chromium.org, tfarina, brettw-cc_chromium.org, ajwong+watch_chromium.org, sadrul

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Aura/ash: On Desktops, use an aura::client to resolve screen coordinates. We can only use aura::Windows when trying to calculate where menus should be displayed. Add a client interface to do this, move the existing usage out of the DesktopNativeWidgetHelperAura and into the client. BUG=125106 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137954

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+170 lines, -32 lines)			Patch
M	chrome/browser/tab_contents/chrome_web_contents_view_delegate_views.cc	View	1	3 chunks	+17 lines, -4 lines	0 comments	Download
M	ui/aura/aura.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	ui/aura/client/screen_position_client.h	View	1 2	1 chunk	+39 lines, -0 lines	0 comments	Download
A	ui/aura/client/screen_position_client.cc	View	1 2	1 chunk	+29 lines, -0 lines	0 comments	Download
M	ui/views/widget/desktop_native_widget_helper_aura.h	View		3 chunks	+9 lines, -3 lines	0 comments	Download
M	ui/views/widget/desktop_native_widget_helper_aura.cc	View	1 2 3	6 chunks	+51 lines, -13 lines	0 comments	Download
M	ui/views/widget/native_widget_aura.cc	View	1 2 3	4 chunks	+20 lines, -5 lines	0 comments	Download
M	ui/views/widget/native_widget_helper_aura.h	View		2 chunks	+3 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/10409011/6001

8 years, 7 months ago (2012-05-18 19:27:08 UTC) #3

Change committed as 137954

Expand Messages | Collapse Messages

Issue 10409011: Aura/ash: On Desktops, use a aura::client to resolve screen coordinates. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Remove redundant client on RootWindow. #

Patch Set 3 : Make the comments not lies. #

Patch Set 4 : Fix merge with trunk. #

Messages