Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Unified Diff: pylib/gyp/xcode_emulation.py

Issue 10409007: mac ninja and make: Add support for GCC_ENABLE_OBJC_GC. (Closed) Base URL: http://gyp.googlecode.com/svn/trunk/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pylib/gyp/xcode_emulation.py
===================================================================
--- pylib/gyp/xcode_emulation.py (revision 1382)
+++ pylib/gyp/xcode_emulation.py (working copy)
@@ -306,7 +306,6 @@
self._WarnUnimplemented('COPY_PHASE_STRIP')
self._WarnUnimplemented('GCC_DEBUGGING_SYMBOLS')
self._WarnUnimplemented('GCC_ENABLE_OBJC_EXCEPTIONS')
- self._WarnUnimplemented('GCC_ENABLE_OBJC_GC')
# TODO: This is exported correctly, but assigning to it is not supported.
self._WarnUnimplemented('MACH_O_TYPE')
@@ -378,10 +377,18 @@
return cflags_cc
def GetCflagsObjC(self, configname):
- """Returns flags that need to be added to .m compilations."""
+ """Returns flags that need to be added to .m and .mm compilations."""
self.configname = configname
+ cflags_objc = []
+
+ gc_policy = self._Settings().get('GCC_ENABLE_OBJC_GC', 'unsupported')
+ if gc_policy == 'supported':
+ cflags_objc.append('-fobjc-gc')
+ elif gc_policy == 'required':
+ cflags_objc.append('-fobjc-gc-only')
+
self.configname = None
- return []
+ return cflags_objc
def GetCflagsObjCC(self, configname):
"""Returns flags that need to be added to .mm compilations."""

Powered by Google App Engine
This is Rietveld 408576698