Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 10409007: mac ninja and make: Add support for GCC_ENABLE_OBJC_GC. (Closed)

Created:
8 years, 7 months ago by Nico
Modified:
8 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

mac ninja and make: Add support for GCC_ENABLE_OBJC_GC. Committed: https://code.google.com/p/gyp/source/detail?r=1384

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -2 lines) Patch
M pylib/gyp/xcode_emulation.py View 1 2 3 4 5 2 chunks +13 lines, -2 lines 0 comments Download
A test/mac/gyptest-objc-gc.py View 1 2 3 1 chunk +45 lines, -0 lines 0 comments Download
A test/mac/objc-gc/c-file.c View 1 chunk +1 line, -0 lines 0 comments Download
A test/mac/objc-gc/cc-file.cc View 1 chunk +1 line, -0 lines 0 comments Download
A test/mac/objc-gc/main.m View 1 chunk +6 lines, -0 lines 0 comments Download
A test/mac/objc-gc/needs-gc.m View 1 chunk +1 line, -0 lines 0 comments Download
A test/mac/objc-gc/needs-gc-mm.mm View 1 chunk +1 line, -0 lines 0 comments Download
A test/mac/objc-gc/test.gyp View 1 2 3 1 chunk +102 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nico
8 years, 7 months ago (2012-05-17 16:48:07 UTC) #1
Mark Mentovai
LGTM https://chromiumcodereview.appspot.com/10409007/diff/6013/test/mac/gyptest-objc-gc.py File test/mac/gyptest-objc-gc.py (right): https://chromiumcodereview.appspot.com/10409007/diff/6013/test/mac/gyptest-objc-gc.py#newcode8 test/mac/gyptest-objc-gc.py:8: Verifies that env vars work with actions, with ...
8 years, 7 months ago (2012-05-17 17:26:35 UTC) #2
Nico
Both done, thanks!
8 years, 7 months ago (2012-05-17 17:32:28 UTC) #3
Mark Mentovai
LGTM
8 years, 7 months ago (2012-05-17 17:36:44 UTC) #4
Nico
The "add objc flags to objcc flags" thing broke tests, so I redid it without ...
8 years, 7 months ago (2012-05-17 17:47:41 UTC) #5
Mark Mentovai
8 years, 7 months ago (2012-05-17 18:00:55 UTC) #6
I was afraid that might happen. Good thing there are tests. LGTM.

Powered by Google App Engine
This is Rietveld 408576698