Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Unified Diff: dart/lib/compiler/implementation/native_handler.dart

Issue 10408087: Parameterize the native_handler with the world/enqueuer. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/lib/compiler/implementation/native_handler.dart
diff --git a/dart/lib/compiler/implementation/native_handler.dart b/dart/lib/compiler/implementation/native_handler.dart
index c567532d78103529d19e7cb1502c6e56807e5c7d..485e51387b4923e01dba5b8f27773c89340e19a3 100644
--- a/dart/lib/compiler/implementation/native_handler.dart
+++ b/dart/lib/compiler/implementation/native_handler.dart
@@ -11,10 +11,11 @@
#import('tree/tree.dart');
#import('util/util.dart');
-void processNativeClasses(CodeEmitterTask emitter,
+void processNativeClasses(Enqueuer world,
+ CodeEmitterTask emitter,
Collection<LibraryElement> libraries) {
for (LibraryElement library in libraries) {
- processNativeClassesInLibrary(emitter, library);
+ processNativeClassesInLibrary(world, emitter, library);
}
}
@@ -33,7 +34,8 @@ void addSubtypes(ClassElement cls,
directSubtypes.add(cls);
}
-void processNativeClassesInLibrary(CodeEmitterTask emitter,
+void processNativeClassesInLibrary(Enqueuer world,
+ CodeEmitterTask emitter,
LibraryElement library) {
bool hasNativeClass = false;
final compiler = emitter.compiler;
@@ -44,7 +46,7 @@ void processNativeClassesInLibrary(CodeEmitterTask emitter,
ClassElement classElement = element;
if (classElement.isNative()) {
hasNativeClass = true;
- compiler.registerInstantiatedClass(classElement);
+ world.registerInstantiatedClass(classElement);
// Also parse the node to know all its methods because
// otherwise it will only be parsed if there is a call to
// one of its constructor.
@@ -59,17 +61,14 @@ void processNativeClassesInLibrary(CodeEmitterTask emitter,
}
}
if (hasNativeClass) {
- final worlds = [compiler.enqueuer.resolution, compiler.enqueuer.codegen];
- for (var world in worlds) {
- world.registerStaticUse(compiler.findHelper(
- const SourceString('dynamicFunction')));
- world.registerStaticUse(compiler.findHelper(
- const SourceString('dynamicSetMetadata')));
- world.registerStaticUse(compiler.findHelper(
- const SourceString('defineProperty')));
- world.registerStaticUse(compiler.findHelper(
- const SourceString('toStringForNativeObject')));
- }
+ world.registerStaticUse(compiler.findHelper(
+ const SourceString('dynamicFunction')));
+ world.registerStaticUse(compiler.findHelper(
+ const SourceString('dynamicSetMetadata')));
+ world.registerStaticUse(compiler.findHelper(
+ const SourceString('defineProperty')));
+ world.registerStaticUse(compiler.findHelper(
+ const SourceString('toStringForNativeObject')));
}
}

Powered by Google App Engine
This is Rietveld 408576698