Issue 10408071: gdata: Fix a crash when adding a new file to a new but deleted directory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10408071: gdata: Fix a crash when adding a new file to a new but deleted directory. (Closed)

Created:
8 years, 7 months ago by satorux1

Modified:
8 years, 7 months ago

Reviewers:
zel

CC:
chromium-reviews, achuith+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

gdata: Fix a crash when adding a new file to a new but deleted directory. FindDirectoryForNewEntry() was crashing when: 1) a new file is added to a new directory in the same delta feed 2) but the new directory entry is marked "deleted" (moved to trash) BUG=127495 TEST=added a unit test for the fix Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138368

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+284 lines, -10 lines)			Patch
M	chrome/browser/chromeos/gdata/gdata_file_system.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system.cc	View	7 chunks	+17 lines, -9 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc	View	1 chunk	+12 lines, -0 lines	0 comments	Download
A	chrome/test/data/chromeos/gdata/delta_file_added_in_new_but_deleted_directory.json	View	1 chunk	+252 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages