Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10408067: [net] Switch TestURLRequestContext to use MockCachingHostResolver. (Closed)

Created:
8 years, 7 months ago by szym
Modified:
8 years, 7 months ago
Reviewers:
eroman, akalin
CC:
chromium-reviews, Aaron Boodman, cbentzel+watch_chromium.org, mihaip-chromium-reviews_chromium.org, darin-cc_chromium.org, mmenke
Visibility:
Public.

Description

[net] Switch TestURLRequestContext and other tests to use MockCachingHostResolver or MockHostResolver. Make explicit when HostResolver::Resolve is expected to never complete in tests. Clean up TestURLRequestContext API. BUG=126016, 128745 TEST=net_unittests; jingle_unittests; sync_unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138413

Patch Set 1 : . #

Patch Set 2 : Fix DEPS. Use custom derived classes of TestURLRequestContext. #

Patch Set 3 : De-linted. #

Patch Set 4 : Rebased to trunk. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -179 lines) Patch
M chrome/browser/extensions/api/web_request/web_request_api_unittest.cc View 4 chunks +9 lines, -2 lines 0 comments Download
M jingle/notifier/base/proxy_resolving_client_socket_unittest.cc View 1 4 chunks +12 lines, -25 lines 0 comments Download
M jingle/notifier/communicator/single_login_attempt_unittest.cc View 1 2 chunks +13 lines, -1 line 0 comments Download
M net/proxy/proxy_script_fetcher_impl_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M net/socket/transport_client_socket_unittest.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M net/socket_stream/socket_stream.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/socket_stream/socket_stream.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M net/socket_stream/socket_stream_unittest.cc View 1 2 11 chunks +18 lines, -17 lines 0 comments Download
M net/url_request/url_request_test_util.h View 1 3 chunks +7 lines, -11 lines 0 comments Download
M net/url_request/url_request_test_util.cc View 5 chunks +13 lines, -55 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 1 2 3 18 chunks +37 lines, -50 lines 0 comments Download
M sync/notifier/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M sync/notifier/p2p_notifier_unittest.cc View 1 2 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
szym
eroman: PTAL changes to net/ and chrome/ akalin: PTAL changes to jingle/ and sync/
8 years, 7 months ago (2012-05-22 21:13:10 UTC) #1
eroman
lgtm
8 years, 7 months ago (2012-05-22 21:21:46 UTC) #2
akalin
sync jingle lgtm
8 years, 7 months ago (2012-05-22 22:18:34 UTC) #3
commit-bot: I haz the power
8 years, 7 months ago (2012-05-22 23:45:36 UTC) #4

Powered by Google App Engine
This is Rietveld 408576698