Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1086)

Unified Diff: ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc

Issue 10408051: [Coverity] Fix uninitialized member, pass-by-val. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc
diff --git a/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc b/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc
index 84960b713d89982bd2e017d12251443ada2243c0..58db5d2c7953e19f0c9bdd95da7bab1453a18b0d 100644
--- a/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc
+++ b/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc
@@ -14,6 +14,7 @@ namespace plugin {
PnaclTranslateThread::PnaclTranslateThread() : subprocesses_should_die_(false),
manifest_(NULL),
+ ld_manifest_(NULL),
obj_file_(NULL),
nexe_file_(NULL),
pexe_wrapper_(NULL),
@@ -23,15 +24,16 @@ PnaclTranslateThread::PnaclTranslateThread() : subprocesses_should_die_(false),
NaClXMutexCtor(&subprocess_mu_);
}
-void PnaclTranslateThread::RunTranslate(pp::CompletionCallback finish_callback,
- const Manifest* manifest,
- const Manifest* ld_manifest,
- LocalTempFile* obj_file,
- LocalTempFile* nexe_file,
- nacl::DescWrapper* pexe_wrapper,
- ErrorInfo* error_info,
- PnaclResources* resources,
- Plugin* plugin) {
+void PnaclTranslateThread::RunTranslate(
+ const pp::CompletionCallback& finish_callback,
+ const Manifest* manifest,
+ const Manifest* ld_manifest,
+ LocalTempFile* obj_file,
+ LocalTempFile* nexe_file,
+ nacl::DescWrapper* pexe_wrapper,
+ ErrorInfo* error_info,
+ PnaclResources* resources,
+ Plugin* plugin) {
PLUGIN_PRINTF(("PnaclTranslateThread::RunTranslate)\n"));
manifest_ = manifest;
ld_manifest_ = ld_manifest;
« no previous file with comments | « ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698