Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Side by Side Diff: ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.h

Issue 10408051: [Coverity] Fix uninitialized member, pass-by-val. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NATIVE_CLIENT_SRC_TRUSTED_PLUGIN_PNACL_TRANSLATE_THREAD_H_ 5 #ifndef NATIVE_CLIENT_SRC_TRUSTED_PLUGIN_PNACL_TRANSLATE_THREAD_H_
6 #define NATIVE_CLIENT_SRC_TRUSTED_PLUGIN_PNACL_TRANSLATE_THREAD_H_ 6 #define NATIVE_CLIENT_SRC_TRUSTED_PLUGIN_PNACL_TRANSLATE_THREAD_H_
7 7
8 #include "native_client/src/include/nacl_macros.h" 8 #include "native_client/src/include/nacl_macros.h"
9 #include "native_client/src/include/nacl_scoped_ptr.h" 9 #include "native_client/src/include/nacl_scoped_ptr.h"
10 #include "native_client/src/include/nacl_string.h" 10 #include "native_client/src/include/nacl_string.h"
(...skipping 15 matching lines...) Expand all
26 class NaClSubprocess; 26 class NaClSubprocess;
27 class Plugin; 27 class Plugin;
28 class PnaclResources; 28 class PnaclResources;
29 29
30 class PnaclTranslateThread { 30 class PnaclTranslateThread {
31 public: 31 public:
32 PnaclTranslateThread(); 32 PnaclTranslateThread();
33 virtual ~PnaclTranslateThread(); 33 virtual ~PnaclTranslateThread();
34 // TODO(jvoung/dschuff): handle surfaway issues when coordinator/plugin 34 // TODO(jvoung/dschuff): handle surfaway issues when coordinator/plugin
35 // goes away. This data may have to be refcounted not touched in that case. 35 // goes away. This data may have to be refcounted not touched in that case.
36 void RunTranslate(pp::CompletionCallback finish_callback, 36 void RunTranslate(const pp::CompletionCallback& finish_callback,
37 const Manifest* manifest, 37 const Manifest* manifest,
38 const Manifest* ld_manifest, 38 const Manifest* ld_manifest,
39 LocalTempFile* obj_file, 39 LocalTempFile* obj_file,
40 LocalTempFile* nexe_file, 40 LocalTempFile* nexe_file,
41 nacl::DescWrapper* pexe_wrapper, 41 nacl::DescWrapper* pexe_wrapper,
42 ErrorInfo* error_info, 42 ErrorInfo* error_info,
43 PnaclResources* resources, 43 PnaclResources* resources,
44 Plugin* plugin); 44 Plugin* plugin);
45 bool SubprocessesShouldDie(); 45 bool SubprocessesShouldDie();
46 // Signal the translate thread and subprocesses that they should stop. 46 // Signal the translate thread and subprocesses that they should stop.
(...skipping 27 matching lines...) Expand all
74 LocalTempFile* obj_file_; 74 LocalTempFile* obj_file_;
75 LocalTempFile* nexe_file_; 75 LocalTempFile* nexe_file_;
76 nacl::DescWrapper* pexe_wrapper_; 76 nacl::DescWrapper* pexe_wrapper_;
77 ErrorInfo *error_info_; 77 ErrorInfo *error_info_;
78 PnaclResources* resources_; 78 PnaclResources* resources_;
79 Plugin* plugin_; 79 Plugin* plugin_;
80 }; 80 };
81 81
82 } 82 }
83 #endif // NATIVE_CLIENT_SRC_TRUSTED_PLUGIN_PNACL_TRANSLATE_THREAD_H_ 83 #endif // NATIVE_CLIENT_SRC_TRUSTED_PLUGIN_PNACL_TRANSLATE_THREAD_H_
OLDNEW
« no previous file with comments | « no previous file | ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698