Issue 10408049: Fixup SimpleDomStorageSystem to no longer use obsolete WebKit API that required returns of previous…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10408049: Fixup SimpleDomStorageSystem to no longer use obsolete WebKit API that required returns of previous… (Closed)

Created:
8 years, 7 months ago by michaeln

Modified:
8 years, 7 months ago

Reviewers:
tony

CC:
chromium-reviews, darin-cc_chromium.org, pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Fixup SimpleDomStorageSystem to no longer use obsolete WebKit API that requires mutators to return previous values. See http://trac.webkit.org/changeset/117797 for details on the API change. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138335

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -23 lines)			Patch
	M	webkit/tools/test_shell/simple_dom_storage_system.cc	View		2 chunks	+15 lines, -23 lines	0 comments	Download

Total messages: 5 (0 generated)

michaeln

On 2012/05/22 16:34:29, tony wrote: > rs LGTM thnx... but what does "rs" mean?

8 years, 7 months ago (2012-05-22 17:44:56 UTC) #3

tony

On 2012/05/22 17:44:56, michaeln wrote: > On 2012/05/22 16:34:29, tony wrote: > > rs LGTM ...

8 years, 7 months ago (2012-05-22 17:53:50 UTC) #4

michaeln

8 years, 7 months ago (2012-05-22 18:11:54 UTC) #5

> rubber stamp :)

Ah... got it... so it's a cya owner review'ism ;)