vm/flow_graph_compiler_x64.cc - Issue 10408048: Avoid redundant pop/push before Throw/ReThrow in the flow-graph compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: vm/flow_graph_compiler_x64.cc

Issue 10408048: Avoid redundant pop/push before Throw/ReThrow in the flow-graph compiler. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: vm/flow_graph_compiler_x64.cc

===================================================================

--- vm/flow_graph_compiler_x64.cc (revision 7829)

+++ vm/flow_graph_compiler_x64.cc (working copy)

@@ -1286,8 +1286,7 @@

void FlowGraphCompiler::VisitThrow(ThrowInstr* instr) {

- LoadValue(RAX, instr->exception());

- __ pushq(RAX);

+ ASSERT(instr->exception()->IsUse());

GenerateCallRuntime(instr->cid(),

instr->token_index(),

instr->try_index(),

@@ -1297,10 +1296,8 @@

void FlowGraphCompiler::VisitReThrow(ReThrowInstr* instr) {

- LoadValue(RAX, instr->exception());

- __ pushq(RAX);

- LoadValue(RAX, instr->stack_trace());

- __ pushq(RAX);

+ ASSERT(instr->exception()->IsUse());

+ ASSERT(instr->stack_trace()->IsUse());

GenerateCallRuntime(instr->cid(),

instr->token_index(),

instr->try_index(),

« no previous file with comments | « no previous file | no next file » | no next file with comments »