Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 10408043: Fix a deadlock in the GPU Video decoding code in the renderer which would occur when the renderer (Closed)

Created:
8 years, 7 months ago by ananta
Modified:
8 years, 7 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Fix a deadlock in the GPU Video decoding code in the renderer which would occur when the renderer thread was waiting to get the next frame for renderering which attempts to grab the VideoRendererBase lock and the gpu video decoder thread would wait on the renderer thread to execute a task while holding the above lock. Fix is to post task the demuxer_stream_->Read call to ensure that the lock is released by the gpu video decoder thread. BUG=129010 R=fischman Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138120

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M media/filters/gpu_video_decoder.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
8 years, 7 months ago (2012-05-21 18:23:46 UTC) #1
Ami GONE FROM CHROMIUM
8 years, 7 months ago (2012-05-21 18:26:53 UTC) #2
LGTM assuming it fixes the deadlock :)

Powered by Google App Engine
This is Rietveld 408576698