make the settings search page bubbles look cool

chrome/browser/resources/options2/search_page.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   /** @const */ var OptionsPage = options.OptionsPage;
 
   /**
    * Encapsulated handling of a search bubble.
    * @constructor
    */
   function SearchBubble(text) {
     var el = cr.doc.createElement('div');
     SearchBubble.decorate(el);
-    el.textContent = text;
+    el.content = text;
     return el;
   }
 
   SearchBubble.decorate = function(el) {
     el.__proto__ = SearchBubble.prototype;
     el.decorate();
   };
 
   SearchBubble.prototype = {
     __proto__: HTMLDivElement.prototype,
 
     decorate: function() {
       this.className = 'search-bubble';
 
+      this.innards_ = cr.doc.createElement('div');
+      this.innards_.className = 'search-bubble-innards';
+      this.appendChild(this.innards_);
+
       // We create a timer to periodically update the position of the bubbles.
       // While this isn't all that desirable, it's the only sure-fire way of
       // making sure the bubbles stay in the correct location as sections
       // may dynamically change size at any time.
       this.intervalId = setInterval(this.updatePosition.bind(this), 250);
     },
 

[Dan Beam, 2012/05/22 03:40:51]

can you annotate the @type?

[Evan Stade, 2012/05/22 03:55:36]

Done.

+    set content(text) {
+      this.innards_.textContent = text;
+    },
+
   /**
    * Attach the bubble to the element.
    */
     attachTo: function(element) {
       var parent = element.parentElement;
       if (!parent)
         return;
       if (parent.tagName == 'TD') {
         // To make absolute positioning work inside a table cell we need
         // to wrap the bubble div into another div with position:relative.
@@ skipping 511 matching lines @@
     // Trim beginning and ending whitespace.
     return text.replace(/^\s+|\s+$/g, '');
   };
 
   // Export
   return {
     SearchPage: SearchPage
   };
 
 });