Issue 10408038: make the settings search page bubbles look cool

Issue 10408038: make the settings search page bubbles look cool (Closed)

Created:
8 years, 7 months ago by Evan Stade

Modified:
8 years, 7 months ago

Reviewers:
Dan Beam

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

make the settings search page bubbles look cool BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138211

Patch Set 3 : now with 10% more transparency #

Total comments: 4

Patch Set 4 : nits #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -17 lines)			Patch
	M	chrome/browser/resources/options2/search_page.css	View	1 2 3	1 chunk	+41 lines, -13 lines	0 comments	Download
	M	chrome/browser/resources/options2/search_page.js	View	1 2 3	3 chunks	+16 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

http://www/~estade/no_crawl/rubadubdub.png mad css hacks \o> /\\ /\

8 years, 7 months ago (2012-05-22 01:22:19 UTC) #1

Dan Beam

lgtm w/nits https://chromiumcodereview.appspot.com/10408038/diff/1005/chrome/browser/resources/options2/search_page.css File chrome/browser/resources/options2/search_page.css (right): https://chromiumcodereview.appspot.com/10408038/diff/1005/chrome/browser/resources/options2/search_page.css#newcode19 chrome/browser/resources/options2/search_page.css:19: top: -1000px; /* minor hack: position off-screen ...

8 years, 7 months ago (2012-05-22 03:40:51 UTC) #4

Evan Stade

8 years, 7 months ago (2012-05-22 03:55:36 UTC) #5

https://chromiumcodereview.appspot.com/10408038/diff/1005/chrome/browser/reso...
File chrome/browser/resources/options2/search_page.css (right):

https://chromiumcodereview.appspot.com/10408038/diff/1005/chrome/browser/reso...
chrome/browser/resources/options2/search_page.css:19: top: -1000px;  /* minor
hack: position off-screen by default */
On 2012/05/22 03:40:51, Dan Beam wrote:
> in comment: \.$ (optionally ^M)

Done.

https://chromiumcodereview.appspot.com/10408038/diff/1005/chrome/browser/reso...
File chrome/browser/resources/options2/search_page.js (right):

https://chromiumcodereview.appspot.com/10408038/diff/1005/chrome/browser/reso...
chrome/browser/resources/options2/search_page.js:40: 
On 2012/05/22 03:40:51, Dan Beam wrote:
> can you annotate the @type?

Done.

Expand Messages | Collapse Messages