Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 10408037: aura: Fix the sythentic mouse-event location. (Closed)

Created:
8 years, 7 months ago by sadrul
Modified:
8 years, 7 months ago
Reviewers:
oshima, sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

aura: Fix the sythentic mouse-event location. The synthetic mouse event is generated at the last mouse DIP-location. But this event gets transformed for DIP again before it gets dispatched. This ends up sending the event with incorrect location. So make sure it starts off with the pixel-location so that the event location gets transformed for DIP only once. BUG=128095 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138104

Patch Set 1 #

Patch Set 2 : alternate-fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M ui/aura/root_window.cc View 1 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sadrul
8 years, 7 months ago (2012-05-19 03:22:53 UTC) #1
sadrul
Patchset2 is a slightly modified, but I think the better, fix.
8 years, 7 months ago (2012-05-19 03:29:22 UTC) #2
oshima
LGTM Thank you for the fix!
8 years, 7 months ago (2012-05-21 16:49:44 UTC) #3
sadrul
+sky for OWNERS
8 years, 7 months ago (2012-05-21 17:08:08 UTC) #4
sky
8 years, 7 months ago (2012-05-21 17:22:19 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698