[Mac] Ensure that browser tests' teardown destroys all browser objects.

[Mac] Ensure that browser tests' teardown destroys all browser objects.

BUG=none
TEST=CHECK(BrowserList::empty()); never fires after QuitBrowsers().

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138002

[Alexei Svitkine (slow), 2012-05-18 19:05:31]

rsesek: review
sky: OWNER approval

[sky, 2012-05-18 19:55:07]

LGTM

[Robert Sesek, 2012-05-18 20:10:15]

LGTM

http://codereview.chromium.org/10408030/diff/1/chrome/test/base/in_process_br...
File chrome/test/base/in_process_browser_test.cc (right):

http://codereview.chromium.org/10408030/diff/1/chrome/test/base/in_process_br...
chrome/test/base/in_process_browser_test.cc:395: // On the Mac, this eventually
reaches -windowWillClose: on
nit: just write this as -[BrowserWindowController windowWillClose:]

http://codereview.chromium.org/10408030/diff/1/chrome/test/base/in_process_br...
chrome/test/base/in_process_browser_test.cc:398: // pump these pending tasks to
ensure all Browsers get deleted.
nit: I'd use the word "messages" instead of "tasks" here because the latter
sounds like a MessageLoop task, rather than a Cocoa task.

[commit-bot: I haz the power, 2012-05-18 22:24:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asvitkine@chromium.org/10408030/10001

[commit-bot: I haz the power, 2012-05-18 22:24:33]

Failed to apply patch for chrome/test/base/in_process_browser_test.cc:
While running patch -p0 --forward --force;
patching file chrome/test/base/in_process_browser_test.cc
Hunk #1 FAILED at 373.
1 out of 1 hunk FAILED -- saving rejects to file
chrome/test/base/in_process_browser_test.cc.rej

[Alexei Svitkine (slow), 2012-05-18 23:50:31]

rebase

[commit-bot: I haz the power, 2012-05-18 23:51:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asvitkine@chromium.org/10408030/6002

[commit-bot: I haz the power, 2012-05-19 01:05:04]

Change committed as 138002