Issue 10408026: Try to fix defines containing '#' characters with cl.exe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10408026: Try to fix defines containing '#' characters with cl.exe. (Closed)

Created:
8 years, 7 months ago by Nico

Modified:
8 years, 7 months ago

Reviewers:
scottmg

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk/

Visibility:
Public.

Try to fix defines containing '#' characters with cl.exe. Committed: https://code.google.com/p/gyp/source/detail?r=1388

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -9 lines)			Patch
M	pylib/gyp/generator/msvs.py	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download
M	pylib/gyp/generator/ninja.py	View	1 2	3 chunks	+12 lines, -6 lines	0 comments	Download
M	test/defines/defines.gyp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	test/defines/gyptest-defines.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	test/defines/gyptest-defines-env-regyp.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Nico

octal instead of hex because hex-escaped go on while there are [0-9a-fA-F] after the \x, ...

8 years, 7 months ago (2012-05-18 15:56:19 UTC) #1

Fun! lgtm