chrome/browser/extensions/extension_menu_manager.cc - Issue 10408019: [Coverity] Pass-by-val to pass-by-ref

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_menu_manager.cc

Issue 10408019: [Coverity] Pass-by-val to pass-by-ref (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_menu_manager.cc

diff --git a/chrome/browser/extensions/extension_menu_manager.cc b/chrome/browser/extensions/extension_menu_manager.cc

index 8f320056daf28b81e7d6b5a675e7a27eb5d3bb04..f0bdca8efaf74809fa502b82317b5ef04e397715 100644

--- a/chrome/browser/extensions/extension_menu_manager.cc

+++ b/chrome/browser/extensions/extension_menu_manager.cc

@@ -29,7 +29,7 @@ namespace {

void SetIdKeyValue(base::DictionaryValue* properties,

const char* key,

- ExtensionMenuItem::Id id) {

+ const ExtensionMenuItem::Id& id) {

if (id.uid == 0)

properties->SetString(key, id.string_uid);

else

« no previous file with comments | « no previous file | no next file » | no next file with comments »