Issue 10408016: Adding native_client/build to the gyp module include path.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10408016: Adding native_client/build to the gyp module include path. (Closed)

Created:
8 years, 7 months ago by bradn

Modified:
8 years, 7 months ago

Reviewers:
Mark Seaborn, bbudge, noelallen1

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Adding native_client/build to the gyp module include path. This will allow nacl's scan_sources.py script to switch to using the pymod_do_main feature in gyp to: - reduce runtime - circumvent command line length limits on windows BUG=None TEST=None R=noelallen@chromium.org,bbudge@chromium.org,mseaborn@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137783

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	build/gyp_chromium	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bradnelson@google.com/10408016/1

8 years, 7 months ago (2012-05-18 00:33:26 UTC) #3

commit-bot: I haz the power

8 years, 7 months ago (2012-05-18 00:33:28 UTC) #4

Failed to apply patch for build/gyp_chromium:
While running patch -p1 --forward --force;
patching file build/gyp_chromium
Hunk #1 FAILED at 22.
1 out of 1 hunk FAILED -- saving rejects to file build/gyp_chromium.rej

Expand Messages | Collapse Messages