Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 10408011: Revive revision 137685 and fix the DEPs file in chrome/browser/sync (Closed)

Created:
8 years, 7 months ago by Munjal (Google)
Modified:
8 years, 7 months ago
Reviewers:
akalin
CC:
chromium-reviews, Raghu Simha, ncarter (slow), pam+watch_chromium.org, tim (not reviewing)
Visibility:
Public.

Description

Revive revision 137685 and fix the DEPs file in chrome/browser/sync BUG=124140 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137922

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -126 lines) Patch
M chrome/browser/sync/DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/sync_backend_host.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sync_prefs.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M sync/notifier/chrome_invalidation_client.h View 1 3 chunks +6 lines, -6 lines 0 comments Download
M sync/notifier/chrome_invalidation_client.cc View 1 4 chunks +7 lines, -7 lines 0 comments Download
M sync/notifier/chrome_invalidation_client_unittest.cc View 1 10 chunks +18 lines, -18 lines 0 comments Download
M sync/notifier/invalidation_notifier.h View 1 3 chunks +6 lines, -6 lines 0 comments Download
M sync/notifier/invalidation_notifier.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M sync/notifier/invalidation_notifier_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + sync/notifier/invalidation_state_tracker.h View 0 chunks +-1 lines, --1 lines 0 comments Download
D sync/notifier/invalidation_version_tracker.h View 1 1 chunk +0 lines, -38 lines 0 comments Download
M sync/notifier/non_blocking_invalidation_notifier.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M sync/notifier/non_blocking_invalidation_notifier.cc View 1 5 chunks +8 lines, -8 lines 0 comments Download
M sync/notifier/non_blocking_invalidation_notifier_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M sync/notifier/sync_notifier_factory.h View 1 3 chunks +6 lines, -6 lines 0 comments Download
M sync/notifier/sync_notifier_factory.cc View 1 4 chunks +9 lines, -9 lines 0 comments Download
M sync/notifier/sync_notifier_factory_unittest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M sync/sync.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M sync/tools/sync_listen_notifications.cc View 1 3 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Munjal (Google)
8 years, 7 months ago (2012-05-17 18:39:19 UTC) #1
akalin
On 2012/05/17 18:39:19, munjal wrote: LGTM
8 years, 7 months ago (2012-05-17 19:05:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/munjal@chromium.org/10408011/1
8 years, 7 months ago (2012-05-17 19:41:08 UTC) #3
commit-bot: I haz the power
Try job failure for 10408011-1 (retry) on mac_rel for step "compile" (clobber build). It's a ...
8 years, 7 months ago (2012-05-17 19:56:01 UTC) #4
akalin
On 2012/05/17 19:56:01, I haz the power (commit-bot) wrote: > Try job failure for 10408011-1 ...
8 years, 7 months ago (2012-05-17 20:13:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/munjal@chromium.org/10408011/1
8 years, 7 months ago (2012-05-17 23:05:24 UTC) #6
commit-bot: I haz the power
Try job failure for 10408011-1 (retry) on mac_rel for step "compile" (clobber build). It's a ...
8 years, 7 months ago (2012-05-17 23:17:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/munjal@chromium.org/10408011/1
8 years, 7 months ago (2012-05-18 17:27:15 UTC) #8
commit-bot: I haz the power
Try job failure for 10408011-1 (retry) on mac_rel for step "compile" (clobber build). It's a ...
8 years, 7 months ago (2012-05-18 17:39:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/munjal@chromium.org/10408011/15001
8 years, 7 months ago (2012-05-18 17:45:13 UTC) #10
commit-bot: I haz the power
8 years, 7 months ago (2012-05-18 17:59:19 UTC) #11
Try job failure for 10408011-15001 (retry) on mac_rel for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698