Issue 10408007: retry 137554 - convert help page to loadTimeData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10408007: retry 137554 - convert help page to loadTimeData (Closed)

Created:
8 years, 7 months ago by Evan Stade

Modified:
8 years, 7 months ago

Reviewers:
Dan Beam

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

retry 137554 - convert help page to loadTimeData BUG=122753 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137691

Patch Set 1 #

Total comments: 1

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -16 lines)			Patch
M	chrome/browser/resources/help/help.html	View	3 chunks	+4 lines, -3 lines	1 comment	Download
M	chrome/browser/resources/help/help.js	View	4 chunks	+12 lines, -13 lines	0 comments	Download
A	chrome/browser/ui/webui/help/help_browsertest.js	View	1 chunk	+21 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/help/help_ui.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

http://codereview.chromium.org/10408007/diff/1/chrome/browser/resources/help/help.html File chrome/browser/resources/help/help.html (right): http://codereview.chromium.org/10408007/diff/1/chrome/browser/resources/help/help.html#newcode81 chrome/browser/resources/help/help.html:81: <if expr="is_macosx"> this is the difference

8 years, 7 months ago (2012-05-17 03:52:17 UTC) #1

Dan Beam

(though I don't understand how this could've triggered a test failure...?)

8 years, 7 months ago (2012-05-17 05:11:21 UTC) #3

Evan Stade

because the string for that button is only defined on mac

8 years, 7 months ago (2012-05-17 16:20:47 UTC) #4

Dan Beam

8 years, 7 months ago (2012-05-17 17:04:45 UTC) #5

On 2012/05/17 16:20:47, Evan Stade wrote:
> because the string for that button is only defined on mac

ah, I see

Expand Messages | Collapse Messages