[Mac] Log stack trace for CHECK in bug 97285.

content/renderer/webplugin_delegate_proxy.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/webplugin_delegate_proxy.h"
 
 #if defined(TOOLKIT_GTK)
 #include <gtk/gtk.h>
 #elif defined(USE_X11)
 #include <cairo/cairo.h>
 #endif
 
 #include <algorithm>
 
+#include "base/auto_reset.h"
 #include "base/basictypes.h"
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/process.h"
 #include "base/string_split.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
@@ skipping 244 matching lines @@
   // Anything else is a named, opaque color or an RGB form with no alpha.
   return false;
 }
 
 bool WebPluginDelegateProxy::Initialize(
     const GURL& url,
     const std::vector<std::string>& arg_names,
     const std::vector<std::string>& arg_values,
     webkit::npapi::WebPlugin* plugin,
     bool load_manually) {
+#if defined(OS_MACOSX)
+  // TODO(shess): Debugging for http://crbug.com/97285 .  See comment
+  // in plugin_channel_host.cc.
+  AutoReset<bool> track_nested_removes(
+      PluginChannelHost::GetRemoveTrackingFlag(), true);
+#endif
+
   IPC::ChannelHandle channel_handle;
   if (!RenderThreadImpl::current()->Send(new ViewHostMsg_OpenChannelToPlugin(
           render_view_->routing_id(), url, page_url_, mime_type_,
           &channel_handle, &info_))) {
     return false;
   }
 
   if (channel_handle.name.empty()) {
     // We got an invalid handle.  Either the plugin couldn't be found (which
     // shouldn't happen, since if we got here the plugin should exist) or the
     // plugin crashed on initialization.
     if (!info_.path.empty()) {
       render_view_->PluginCrashed(info_.path);
       LOG(ERROR) << "Plug-in crashed on start";
 
       // Return true so that the plugin widget is created and we can paint the
       // crashed plugin there.
       return true;
     }
     LOG(ERROR) << "Plug-in couldn't be found";
     return false;
   }
 
   scoped_refptr<PluginChannelHost> channel_host(
       PluginChannelHost::GetPluginChannelHost(
           channel_handle, ChildProcess::current()->io_message_loop_proxy()));
   if (!channel_host.get()) {
     LOG(ERROR) << "Couldn't get PluginChannelHost";
     return false;
   }

[piman, 2012/05/16 23:19:27]

Is it ok not to reset here? You might get RemoveRoute from the couple of sync
message calls below.

[Scott Hess - ex-Googler, 2012/05/17 22:08:12]

Hmm.  auto_reset<> doesn't have a Reset(), but I can wrap it in a scoped_ptr<>,
which is ugly as heck, but this is already ugly as sin, so ...

 
   int instance_id;
   bool result = channel_host->Send(new PluginMsg_CreateInstance(
       mime_type_, &instance_id));
   if (!result) {
     LOG(ERROR) << "Couldn't send PluginMsg_CreateInstance";
     return false;
   }
 
   channel_host_ = channel_host;
@@ skipping 1154 matching lines @@
 }
 #endif
 
 void WebPluginDelegateProxy::OnURLRedirectResponse(bool allow,
                                                    int resource_id) {
   if (!plugin_)
     return;
 
   plugin_->URLRedirectResponse(allow, resource_id);
 }