chrome/browser/net/sqlite_persistent_cookie_store_unittest.cc - Issue 10407124: Don't force non-session only cookies to be session only cookies, instead delete on shutdown

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/sqlite_persistent_cookie_store_unittest.cc

Issue 10407124: Don't force non-session only cookies to be session only cookies, instead delete on shutdown (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/net/sqlite_persistent_cookie_store.cc ('K') | « chrome/browser/net/sqlite_persistent_cookie_store_perftest.cc ('k') | chrome/browser/profiles/profile_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/net/sqlite_persistent_cookie_store_unittest.cc

diff --git a/chrome/browser/net/sqlite_persistent_cookie_store_unittest.cc b/chrome/browser/net/sqlite_persistent_cookie_store_unittest.cc

index 11d1cfecf8c0be4130b612014b7fb49bd24c03f6..141f8ff7409bfb6cbcf9f47f1d1f356df18ab739 100644

--- a/chrome/browser/net/sqlite_persistent_cookie_store_unittest.cc

+++ b/chrome/browser/net/sqlite_persistent_cookie_store_unittest.cc

@@ -67,7 +67,8 @@ class SQLitePersistentCookieStoreTest : public testing::Test {

std::vector<net::CookieMonster::CanonicalCookie*>* cookies) {

store_ = new SQLitePersistentCookieStore(

temp_dir_.path().Append(chrome::kCookieFilename),

- restore_old_session_cookies);

+ restore_old_session_cookies,

+ NULL);

Load(cookies);

}

@@ -223,7 +224,7 @@ TEST_F(SQLitePersistentCookieStoreTest, TestLoadCookiesForKey) {

DestroyStore();

store_ = new SQLitePersistentCookieStore(

- temp_dir_.path().Append(chrome::kCookieFilename), false);

+ temp_dir_.path().Append(chrome::kCookieFilename), false, NULL);

// Posting a blocking task to db_thread_ makes sure that the DB thread waits

// until both Load and LoadCookiesForKey have been posted to its task queue.

BrowserThread::PostTask(