Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1934)

Unified Diff: chrome/browser/extensions/extension_tabs_module.cc

Issue 10407122: Get rid of the last RenderViewHostDelegate usage in chrome. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_tabs_module.cc
===================================================================
--- chrome/browser/extensions/extension_tabs_module.cc (revision 138434)
+++ chrome/browser/extensions/extension_tabs_module.cc (working copy)
@@ -1527,13 +1527,10 @@
return false;
}
- // Close the tab in this convoluted way, since there's a chance that the tab
- // is being dragged, or we're in some other nested event loop. This code
- // path should ensure that the tab is safely closed under such
- // circumstances, whereas |Browser::CloseTabContents()| does not.
- RenderViewHost* render_view_host =
- contents->web_contents()->GetRenderViewHost();
- render_view_host->GetDelegate()->Close(render_view_host);
+ // There's a chance that the tab is being dragged, or we're in some other
+ // nested event loop. This code path ensures that the tab is safely closed
+ // under such circumstances, whereas |Browser::CloseTabContents()| does not.
+ contents->web_contents()->Close();
}
return true;
}
« no previous file with comments | « chrome/browser/extensions/extension_process_manager.cc ('k') | chrome/browser/media/media_stream_capture_indicator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698