chrome/browser/speech/speech_input_extension_apitest.cc - Issue 10407120: Moving tray icon and notification balloon for background speech recognition sessions to ChromeSpeec…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/speech/speech_input_extension_apitest.cc

Issue 10407120: Moving tray icon and notification balloon for background speech recognition sessions to ChromeSpeec… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed win issued ("interface" member clashes with a VS macro name, sigh) Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/speech/chrome_speech_recognition_preferences.cc ('k') | chrome/browser/speech/speech_input_extension_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/speech/speech_input_extension_apitest.cc

diff --git a/chrome/browser/speech/speech_input_extension_apitest.cc b/chrome/browser/speech/speech_input_extension_apitest.cc

index 3718a038487dc1b40ad39c3d1dc09c48cfa2d2a5..59b99589e2e5d1404e017ec502d8987fdf86e06e 100644

--- a/chrome/browser/speech/speech_input_extension_apitest.cc

+++ b/chrome/browser/speech/speech_input_extension_apitest.cc

@@ -81,11 +81,11 @@ class SpeechInputExtensionApiTest : public ExtensionApiTest,

virtual void StartRecording(

content::SpeechRecognitionEventListener* listener,

net::URLRequestContextGetter* context_getter,

- const string16& extension_name,

+ const std::string& extension_name,

const std::string& language,

const std::string& grammar,

bool filter_profanities,

- bool show_notification) OVERRIDE;

+ int render_process_id) OVERRIDE;

virtual void StopRecording(bool recognition_failed) OVERRIDE;

@@ -136,11 +136,11 @@ SpeechInputExtensionApiTest::~SpeechInputExtensionApiTest() {

void SpeechInputExtensionApiTest::StartRecording(

content::SpeechRecognitionEventListener* listener,

net::URLRequestContextGetter* context_getter,

- const string16& extension_name,

+ const std::string& extension_name,

const std::string& language,

const std::string& grammar,

bool filter_profanities,

- bool show_notification) {

+ int render_process_id) {

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

recognizer_is_valid_ = true;