Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: tools/testing/dart/test_runner.dart

Issue 10407118: Fix bug in refactoring of string concatenations in test code. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for executing tests. 6 * Classes and methods for executing tests.
7 * 7 *
8 * This module includes: 8 * This module includes:
9 * - Managing parallel execution of tests, including timeout checks. 9 * - Managing parallel execution of tests, including timeout checks.
10 * - Evaluating the output of each test as pass/fail/crash/timeout. 10 * - Evaluating the output of each test as pass/fail/crash/timeout.
(...skipping 1079 matching lines...) Expand 10 before | Expand all | Expand 10 after
1090 throw new Exception('Unable to find inactive batch runner.'); 1090 throw new Exception('Unable to find inactive batch runner.');
1091 } 1091 }
1092 1092
1093 void _tryRunTest() { 1093 void _tryRunTest() {
1094 _checkDone(); 1094 _checkDone();
1095 if (_numProcesses < _maxProcesses && !_tests.isEmpty()) { 1095 if (_numProcesses < _maxProcesses && !_tests.isEmpty()) {
1096 TestCase test = _tests.removeFirst(); 1096 TestCase test = _tests.removeFirst();
1097 if (_listTests) { 1097 if (_listTests) {
1098 var fields = [test.displayName, 1098 var fields = [test.displayName,
1099 Strings.join(new List.from(test.expectedOutcomes), ','), 1099 Strings.join(new List.from(test.expectedOutcomes), ','),
1100 test.isNegative]; 1100 test.isNegative.toString()];
1101 fields.addAll(test.commands.last().arguments); 1101 fields.addAll(test.commands.last().arguments);
1102 print(Strings.join(fields, '\t')); 1102 print(Strings.join(fields, '\t'));
1103 return; 1103 return;
1104 } 1104 }
1105 if (test.usesWebDriver && _needsSelenium && !_isSeleniumAvailable) { 1105 if (test.usesWebDriver && _needsSelenium && !_isSeleniumAvailable) {
1106 // The server is not ready to run Selenium tests. Put the test back in 1106 // The server is not ready to run Selenium tests. Put the test back in
1107 // the queue. Avoid spin-polling by using a timeout. 1107 // the queue. Avoid spin-polling by using a timeout.
1108 _tests.add(test); 1108 _tests.add(test);
1109 new Timer(1000, (timer) {_tryRunTest();}); // Don't lose a process. 1109 new Timer(1000, (timer) {_tryRunTest();}); // Don't lose a process.
1110 return; 1110 return;
(...skipping 25 matching lines...) Expand all
1136 // the developer doesn't waste his or her time trying to fix a bunch of 1136 // the developer doesn't waste his or her time trying to fix a bunch of
1137 // tests that appear to be broken but were actually just flakes that 1137 // tests that appear to be broken but were actually just flakes that
1138 // didn't get retried because there had already been one failure. 1138 // didn't get retried because there had already been one failure.
1139 bool allowRetry = _MAX_FAILED_NO_RETRY > _progress.numFailedTests; 1139 bool allowRetry = _MAX_FAILED_NO_RETRY > _progress.numFailedTests;
1140 new RunningProcess(test, allowRetry, this).start(); 1140 new RunningProcess(test, allowRetry, this).start();
1141 } 1141 }
1142 _numProcesses++; 1142 _numProcesses++;
1143 } 1143 }
1144 } 1144 }
1145 } 1145 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698