Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 10407115: Always pass FileSystemContext to ObfuscatedFileUtil operations (Closed)

Created:
8 years, 7 months ago by kinuko
Modified:
8 years, 7 months ago
Reviewers:
tzik
CC:
chromium-reviews, kinuko+watch, darin-cc_chromium.org
Visibility:
Public.

Description

Always pass FileSystemContext to ObfuscatedFileUtil operations Now it may always refer operation_context->file_system_context() as it tries to invalidate the usage cache whenever it finds inconsistency. BUG=129303 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138444

Patch Set 1 #

Patch Set 2 : build fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -17 lines) Patch
M chrome/browser/browsing_data_file_system_helper.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M webkit/fileapi/file_system_context.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/fileapi/file_system_quota_client.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/fileapi/file_system_quota_util.h View 2 chunks +6 lines, -2 lines 0 comments Download
M webkit/fileapi/file_system_test_helper.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/sandbox_mount_point_provider.h View 2 chunks +2 lines, -0 lines 0 comments Download
M webkit/fileapi/sandbox_mount_point_provider.cc View 3 chunks +9 lines, -4 lines 0 comments Download
M webkit/fileapi/sandbox_mount_point_provider_unittest.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M webkit/fileapi/test_mount_point_provider.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kinuko
8 years, 7 months ago (2012-05-23 05:41:31 UTC) #1
tzik
8 years, 7 months ago (2012-05-23 05:53:11 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698