Issue 10407110: Adds clipping to the tabs when stacked. This is necessary so we don't

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10407110: Adds clipping to the tabs when stacked. This is necessary so we don't (Closed)

Created:
8 years, 7 months ago by sky

Modified:
8 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Adds clipping to the tabs when stacked. This is necessary so we don't paint a heavy shadow when tabs are stacked. BUG=128743 TEST=none R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138471

Patch Set 1 #

Patch Set 2 : Fix test #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+92 lines, -1 line)			Patch
M	chrome/browser/ui/views/tabs/tab.cc	View		2 chunks	+13 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/tab_controller.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/tab_strip.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/tab_strip.cc	View		2 chunks	+68 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/tab_unittest.cc	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/touch_tab_strip_layout.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/10407110/2001

8 years, 7 months ago (2012-05-23 04:15:09 UTC) #3

commit-bot: I haz the power

8 years, 7 months ago (2012-05-23 06:25:56 UTC) #4

Try job failure for 10407110-2001 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

Expand Messages | Collapse Messages