Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 10407105: Improve error messaging of webRequest API in case of conflicts (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed Evan's comments Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service.cc
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
index 9442e65cc7ef42bd1dc9aaeb1dd80b9d90748062..3d3fa936691cf7ac429cdc2a4a1daa0f359f9472 100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -367,7 +367,6 @@ ExtensionService::ExtensionService(Profile* profile,
browser_terminating_(false),
app_sync_bundle_(ALLOW_THIS_IN_INITIALIZER_LIST(this)),
extension_sync_bundle_(ALLOW_THIS_IN_INITIALIZER_LIST(this)),
- extension_warnings_(profile),
app_shortcut_manager_(profile) {
CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
@@ -869,12 +868,6 @@ bool ExtensionService::UninstallExtension(
// Track the uninstallation.
UMA_HISTOGRAM_ENUMERATION("Extensions.ExtensionUninstalled", 1, 2);
- // Uninstalling one extension might have solved the problems of others.
- // Therefore, we clear warnings of this type for all extensions.
- std::set<ExtensionWarningSet::WarningType> warnings;
- extension_warnings_.GetWarningsAffectingExtension(extension_id, &warnings);
- extension_warnings_.ClearWarnings(warnings);
-
return true;
}
@@ -973,12 +966,6 @@ void ExtensionService::DisableExtension(
}
SyncExtensionChangeIfNeeded(*extension);
-
- // Deactivating one extension might have solved the problems of others.
- // Therefore, we clear warnings of this type for all extensions.
- std::set<ExtensionWarningSet::WarningType> warnings;
- extension_warnings_.GetWarningsAffectingExtension(extension_id, &warnings);
- extension_warnings_.ClearWarnings(warnings);
}
void ExtensionService::GrantPermissionsAndEnableExtension(

Powered by Google App Engine
This is Rietveld 408576698