Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: chrome/browser/extensions/api/web_request/web_request_api_helpers.h

Issue 10407105: Improve error messaging of webRequest API in case of conflicts (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed Evan's comments Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/web_request/web_request_api_helpers.h
diff --git a/chrome/browser/extensions/api/web_request/web_request_api_helpers.h b/chrome/browser/extensions/api/web_request/web_request_api_helpers.h
index f21614af6a80f5bf9d5c9d4e7be1e72271407743..50e101c35cda123bf37c22981a77416663c59a17 100644
--- a/chrome/browser/extensions/api/web_request/web_request_api_helpers.h
+++ b/chrome/browser/extensions/api/web_request/web_request_api_helpers.h
@@ -15,6 +15,7 @@
#include "base/memory/linked_ptr.h"
#include "base/memory/scoped_ptr.h"
#include "base/time.h"
+#include "chrome/browser/extensions/extension_warning_set.h"
#include "googleurl/src/gurl.h"
#include "net/base/auth.h"
#include "net/http/http_request_headers.h"
@@ -223,7 +224,7 @@ void MergeCancelOfResponses(
void MergeOnBeforeRequestResponses(
const EventResponseDeltas& deltas,
GURL* new_url,
- std::set<std::string>* conflicting_extensions,
+ extensions::ExtensionWarningSet* conflicting_extensions,
const net::BoundNetLog* net_log);
// Modifies the "Cookie" header in |request_headers| according to
// |deltas.request_cookie_modifications|. Conflicts are currently ignored
@@ -231,14 +232,14 @@ void MergeOnBeforeRequestResponses(
void MergeCookiesInOnBeforeSendHeadersResponses(
const EventResponseDeltas& deltas,
net::HttpRequestHeaders* request_headers,
- std::set<std::string>* conflicting_extensions,
+ extensions::ExtensionWarningSet* conflicting_extensions,
const net::BoundNetLog* net_log);
// Modifies the headers in |request_headers| according to |deltas|. Conflicts
// are tried to be resolved.
void MergeOnBeforeSendHeadersResponses(
const EventResponseDeltas& deltas,
net::HttpRequestHeaders* request_headers,
- std::set<std::string>* conflicting_extensions,
+ extensions::ExtensionWarningSet* conflicting_extensions,
const net::BoundNetLog* net_log);
// Modifies the "Set-Cookie" headers in |override_response_headers| according to
// |deltas.response_cookie_modifications|. If |override_response_headers| is
@@ -248,7 +249,7 @@ void MergeCookiesInOnHeadersReceivedResponses(
const EventResponseDeltas& deltas,
const net::HttpResponseHeaders* original_response_headers,
scoped_refptr<net::HttpResponseHeaders>* override_response_headers,
- std::set<std::string>* conflicting_extensions,
+ extensions::ExtensionWarningSet* conflicting_extensions,
const net::BoundNetLog* net_log);
// Stores a copy of |original_response_header| into |override_response_headers|
// that is modified according to |deltas|. If |deltas| does not instruct to
@@ -257,7 +258,7 @@ void MergeOnHeadersReceivedResponses(
const EventResponseDeltas& deltas,
const net::HttpResponseHeaders* original_response_headers,
scoped_refptr<net::HttpResponseHeaders>* override_response_headers,
- std::set<std::string>* conflicting_extensions,
+ extensions::ExtensionWarningSet* conflicting_extensions,
const net::BoundNetLog* net_log);
// Merge the responses of blocked onAuthRequired handlers. The first
// registered listener that supplies authentication credentials in a response,
@@ -268,7 +269,7 @@ void MergeOnHeadersReceivedResponses(
bool MergeOnAuthRequiredResponses(
const EventResponseDeltas& deltas,
net::AuthCredentials* auth_credentials,
- std::set<std::string>* conflicting_extensions,
+ extensions::ExtensionWarningSet* conflicting_extensions,
const net::BoundNetLog* net_log);
// Returns whether |type| is a ResourceType that is handled by the web request

Powered by Google App Engine
This is Rietveld 408576698