Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: chrome/browser/extensions/extension_global_error_badge.cc

Issue 10407105: Improve error messaging of webRequest API in case of conflicts (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed Evan's comments Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_global_error_badge.cc
diff --git a/chrome/browser/extensions/extension_global_error_badge.cc b/chrome/browser/extensions/extension_global_error_badge.cc
deleted file mode 100644
index 70f37653de9506501bd9a68f5edd0014284a8fcd..0000000000000000000000000000000000000000
--- a/chrome/browser/extensions/extension_global_error_badge.cc
+++ /dev/null
@@ -1,83 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/browser/extensions/extension_global_error_badge.h"
-
-#include "base/logging.h"
-#include "chrome/app/chrome_command_ids.h"
-#include "chrome/browser/extensions/extension_service.h"
-#include "chrome/browser/profiles/profile.h"
-#include "chrome/browser/ui/browser.h"
-#include "chrome/browser/ui/browser_commands.h"
-#include "grit/generated_resources.h"
-#include "ui/base/l10n/l10n_util.h"
-
-ExtensionGlobalErrorBadge::ExtensionGlobalErrorBadge() {}
-
-ExtensionGlobalErrorBadge::~ExtensionGlobalErrorBadge() {}
-
-bool ExtensionGlobalErrorBadge::HasBadge() {
- return true;
-}
-
-bool ExtensionGlobalErrorBadge::HasMenuItem() {
- return true;
-}
-
-int ExtensionGlobalErrorBadge::MenuItemCommandID() {
- return GetMenuItemCommandID();
-}
-
-string16 ExtensionGlobalErrorBadge::MenuItemLabel() {
- return l10n_util::GetStringUTF16(IDS_EXTENSION_WARNINGS_WRENCH_MENU_ITEM);
-}
-
-void ExtensionGlobalErrorBadge::ExecuteMenuItem(Browser* browser) {
- ExtensionService* extension_service =
- browser->profile()->GetExtensionService();
-
- // Suppress all current warnings in the extension service from triggering
- // a badge on the wrench menu in the future of this session.
- extension_service->extension_warnings()->SuppressBadgeForCurrentWarnings();
-
- chrome::ExecuteCommand(browser, IDC_MANAGE_EXTENSIONS);
-}
-
-bool ExtensionGlobalErrorBadge::HasBubbleView() {
- return false;
-}
-
-string16 ExtensionGlobalErrorBadge::GetBubbleViewTitle() {
- return string16();
-}
-
-string16 ExtensionGlobalErrorBadge::GetBubbleViewMessage() {
- return string16();
-}
-
-string16 ExtensionGlobalErrorBadge::GetBubbleViewAcceptButtonLabel() {
- return string16();
-}
-
-string16 ExtensionGlobalErrorBadge::GetBubbleViewCancelButtonLabel() {
- return string16();
-}
-
-void ExtensionGlobalErrorBadge::OnBubbleViewDidClose(Browser* browser) {
-}
-
-void ExtensionGlobalErrorBadge::BubbleViewAcceptButtonPressed(
- Browser* browser) {
- NOTREACHED();
-}
-
-void ExtensionGlobalErrorBadge::BubbleViewCancelButtonPressed(
- Browser* browser) {
- NOTREACHED();
-}
-
-// static
-int ExtensionGlobalErrorBadge::GetMenuItemCommandID() {
- return IDC_EXTENSION_ERRORS;
-}

Powered by Google App Engine
This is Rietveld 408576698