Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.h

Issue 10407105: Improve error messaging of webRequest API in case of conflicts (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Store ExtensionWarnings as values in set rather than pointers Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/extensions/extension_settings_handler.h
diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.h b/chrome/browser/ui/webui/extensions/extension_settings_handler.h
index aba16eb824230c73d9cc28f835e743ad8cc28748..fce0fe01c15b21b8c323636b3aaab6b8e4b63c67 100644
--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.h
+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.h
@@ -13,7 +13,6 @@
#include "chrome/browser/api/prefs/pref_change_registrar.h"
#include "chrome/browser/extensions/extension_install_ui.h"
#include "chrome/browser/extensions/extension_uninstall_dialog.h"
-#include "chrome/browser/extensions/extension_warning_set.h"
#include "chrome/common/extensions/extension_resource.h"
#include "content/public/browser/navigation_controller.h"
#include "content/public/browser/notification_observer.h"
@@ -36,6 +35,7 @@ class ListValue;
namespace extensions {
class Extension;
class ExtensionHost;
+class ExtensionWarningService;
class ManagementPolicy;
}
@@ -72,7 +72,7 @@ class ExtensionSettingsHandler : public content::WebUIMessageHandler,
base::DictionaryValue* CreateExtensionDetailValue(
const extensions::Extension* extension,
const std::vector<ExtensionPage>& pages,
- const ExtensionWarningSet* warning_set);
+ const extensions::ExtensionWarningService* warning_set);
void GetLocalizedValues(base::DictionaryValue* localized_strings);

Powered by Google App Engine
This is Rietveld 408576698