Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4112)

Unified Diff: chrome/browser/extensions/extension_system.h

Issue 10407105: Improve error messaging of webRequest API in case of conflicts (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Store ExtensionWarnings as values in set rather than pointers Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_system.h
diff --git a/chrome/browser/extensions/extension_system.h b/chrome/browser/extensions/extension_system.h
index 93cec349945303769fb860f751c04081e95975fd..d536adaae9484e7004c73585d6aaa1cc4fc4784b 100644
--- a/chrome/browser/extensions/extension_system.h
+++ b/chrome/browser/extensions/extension_system.h
@@ -30,6 +30,7 @@ class EventRouter;
class Extension;
class ExtensionPrefs;
class ExtensionSystemSharedFactory;
+class ExtensionWarningService;
class LazyBackgroundTaskQueue;
class ManagementPolicy;
class MessageService;
@@ -116,6 +117,9 @@ class ExtensionSystem : public ProfileKeyedService {
virtual ApiResourceManager<UsbDeviceResource>*
usb_device_resource_manager() = 0;
+ // The ExtensionWarningService is created at startup.
+ virtual ExtensionWarningService* warning_service() = 0;
+
// Called by the ExtensionService that lives in this system. Gives the
// info map a chance to react to the load event before the EXTENSION_LOADED
// notification has fired. The purpose for handling this event first is to
@@ -168,6 +172,7 @@ class ExtensionSystemImpl : public ExtensionSystem {
virtual ApiResourceManager<Socket>* socket_manager() OVERRIDE;
virtual ApiResourceManager<UsbDeviceResource>* usb_device_resource_manager()
OVERRIDE;
+ virtual ExtensionWarningService* warning_service() OVERRIDE;
virtual void RegisterExtensionWithRequestContexts(
const Extension* extension) OVERRIDE;
@@ -244,6 +249,7 @@ class ExtensionSystemImpl : public ExtensionSystem {
UsbDeviceResource> > usb_device_resource_manager_;
scoped_ptr<RulesRegistryService> rules_registry_service_;
+ scoped_ptr<ExtensionWarningService> extension_warning_service_;
DISALLOW_COPY_AND_ASSIGN(ExtensionSystemImpl);
};

Powered by Google App Engine
This is Rietveld 408576698