Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: chrome/browser/extensions/extension_global_error_badge.cc

Issue 10407105: Improve error messaging of webRequest API in case of conflicts (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Store ExtensionWarnings as values in set rather than pointers Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_global_error_badge.cc
diff --git a/chrome/browser/extensions/extension_global_error_badge.cc b/chrome/browser/extensions/extension_global_error_badge.cc
index 70f37653de9506501bd9a68f5edd0014284a8fcd..a4c55c53db36db942eef6fbb655498640eba1cd8 100644
--- a/chrome/browser/extensions/extension_global_error_badge.cc
+++ b/chrome/browser/extensions/extension_global_error_badge.cc
@@ -6,7 +6,8 @@
#include "base/logging.h"
#include "chrome/app/chrome_command_ids.h"
-#include "chrome/browser/extensions/extension_service.h"
+#include "chrome/browser/extensions/extension_system.h"
+#include "chrome/browser/extensions/extension_warning_set.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_commands.h"
@@ -34,12 +35,12 @@ string16 ExtensionGlobalErrorBadge::MenuItemLabel() {
}
void ExtensionGlobalErrorBadge::ExecuteMenuItem(Browser* browser) {
- ExtensionService* extension_service =
- browser->profile()->GetExtensionService();
+ extensions::ExtensionWarningService* warning_service =
+ extensions::ExtensionSystem::Get(browser->profile())->warning_service();
// Suppress all current warnings in the extension service from triggering
// a badge on the wrench menu in the future of this session.
- extension_service->extension_warnings()->SuppressBadgeForCurrentWarnings();
+ warning_service->SuppressBadgeForCurrentWarnings();
chrome::ExecuteCommand(browser, IDC_MANAGE_EXTENSIONS);
}

Powered by Google App Engine
This is Rietveld 408576698