chrome/browser/extensions/extension_global_error_badge.h - Issue 10407105: Improve error messaging of webRequest API in case of conflicts

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/extension_global_error_badge.h

Issue 10407105: Improve error messaging of webRequest API in case of conflicts (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed Evan's comments Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/extensions/api/web_request/web_request_api_unittest.cc ('k') | chrome/browser/extensions/extension_global_error_badge.cc » ('j') | chrome/browser/ui/webui/extensions/extension_settings_handler.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	(Empty)
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.

4

5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_GLOBAL_ERROR_BADGE_H_

6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_GLOBAL_ERROR_BADGE_H_

7

8 #include "base/basictypes.h"

9 #include "base/compiler_specific.h"

10 #include "chrome/browser/ui/global_error/global_error.h"

11

12 // Non-modal GlobalError implementation that warns the user if extensions

13 // created warnings or errors. If the user clicks on the wrench menu, the user

14 // is redirected to chrome://extensions to inspect the errors.

15 //

16 // This class is a candidate to be merged with ExtensionGlobalError once

17 // it is finished.

18 class ExtensionGlobalErrorBadge : public GlobalError {

19 public:

20 ExtensionGlobalErrorBadge();

21 virtual ~ExtensionGlobalErrorBadge();

22

23 // Implementation for GlobalError:

24 virtual bool HasBadge() OVERRIDE;

25

26 virtual bool HasMenuItem() OVERRIDE;

27 virtual int MenuItemCommandID() OVERRIDE;

28 virtual string16 MenuItemLabel() OVERRIDE;

29 virtual void ExecuteMenuItem(Browser* browser) OVERRIDE;

30

31 virtual bool HasBubbleView() OVERRIDE;

32 virtual string16 GetBubbleViewTitle() OVERRIDE;

33 virtual string16 GetBubbleViewMessage() OVERRIDE;

34 virtual string16 GetBubbleViewAcceptButtonLabel() OVERRIDE;

35 virtual string16 GetBubbleViewCancelButtonLabel() OVERRIDE;

36 virtual void OnBubbleViewDidClose(Browser* browser) OVERRIDE;

37 virtual void BubbleViewAcceptButtonPressed(Browser* browser) OVERRIDE;

38 virtual void BubbleViewCancelButtonPressed(Browser* browser) OVERRIDE;

39

40 static int GetMenuItemCommandID();

41 private:

42 DISALLOW_COPY_AND_ASSIGN(ExtensionGlobalErrorBadge);

43 };

44

45 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_GLOBAL_ERROR_BADGE_H_

OLD	NEW