Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 10407098: Fix EtwTraceConsumerDataTest fixture. (Closed)

Created:
8 years, 7 months ago by Sigurður Ásgeirsson
Modified:
8 years, 7 months ago
CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org
Visibility:
Public.

Description

Fix EtwTraceConsumerDataTest fixture. BUG=129129 TEST=The unittest no longer fails on trybots. Committed at http://crrev.com/138352.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M base/win/event_trace_consumer_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Sigurður Ásgeirsson
PTAL Mark for owner's approval. Greg for content. This is a silly mistake that only ...
8 years, 7 months ago (2012-05-22 17:51:42 UTC) #1
Mark Mentovai
LGTM
8 years, 7 months ago (2012-05-22 17:53:22 UTC) #2
grt (UTC plus 2)
lgtm
8 years, 7 months ago (2012-05-22 18:25:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/siggi@chromium.org/10407098/1
8 years, 7 months ago (2012-05-22 18:30:29 UTC) #4
commit-bot: I haz the power
Try job failure for 10407098-1 (retry) on win_rel for steps "check_deps, unit_tests, sync_unit_tests" (clobber build). ...
8 years, 7 months ago (2012-05-22 22:29:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/siggi@chromium.org/10407098/1
8 years, 7 months ago (2012-05-23 06:42:31 UTC) #6
commit-bot: I haz the power
8 years, 7 months ago (2012-05-23 06:42:34 UTC) #7
Failed to apply patch for base/win/event_trace_consumer_unittest.cc:
While running patch -p1 --forward --force;
patching file base/win/event_trace_consumer_unittest.cc
Hunk #1 FAILED at 282.
1 out of 1 hunk FAILED -- saving rejects to file
base/win/event_trace_consumer_unittest.cc.rej

Powered by Google App Engine
This is Rietveld 408576698