Ensure integrity of ASCII strings.

Ensure integrity of ASCII strings.


BUG=v8:2128
TEST=

Committed: https://code.google.com/p/v8/source/detail?r=11622

[Yang, 2012-05-22 10:25:19]

PTAL.

This makes sure that ASCII strings only have characters in the range 0-127.

[Michael Starzinger, 2012-05-22 12:13:05]

https://chromiumcodereview.appspot.com/10407090/diff/1/src/heap-inl.h
File src/heap-inl.h (right):

https://chromiumcodereview.appspot.com/10407090/diff/1/src/heap-inl.h#newcode599
src/heap-inl.h:599: // TODO(yangguo): check that the object is indeed an
external string.
Can we use ASSERT(obj->IsExternalString()) and be done with this TODO or am I
missing something?

https://chromiumcodereview.appspot.com/10407090/diff/1/src/heap-inl.h#newcode609
src/heap-inl.h:609: // TODO(yangguo): check that the object is indeed an
external string.
Likewise.

https://chromiumcodereview.appspot.com/10407090/diff/1/src/heap.cc
File src/heap.cc (right):

https://chromiumcodereview.appspot.com/10407090/diff/1/src/heap.cc#newcode4501
src/heap.cc:4501: for (int i = 0; i < length; i++) {
Can we use memset() here instead?

[Yang, 2012-05-22 12:23:10]

please take another look.

http://codereview.chromium.org/10407090/diff/1/src/heap-inl.h
File src/heap-inl.h (right):

http://codereview.chromium.org/10407090/diff/1/src/heap-inl.h#newcode599
src/heap-inl.h:599: // TODO(yangguo): check that the object is indeed an
external string.
On 2012/05/22 12:13:05, Michael Starzinger wrote:
> Can we use ASSERT(obj->IsExternalString()) and be done with this TODO or am I
> missing something?

I added this because we seem to have problems where sometimes there are
sequential strings registered to the external string table, which should not
happen. I will continue to investigate that, but am putting this on hold for
now.

http://codereview.chromium.org/10407090/diff/1/src/heap.cc
File src/heap.cc (right):

http://codereview.chromium.org/10407090/diff/1/src/heap.cc#newcode4501
src/heap.cc:4501: for (int i = 0; i < length; i++) {
On 2012/05/22 12:13:05, Michael Starzinger wrote:
> Can we use memset() here instead?

Done.

[Michael Starzinger, 2012-05-22 12:23:41]

LGTM.