Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1489)

Issue 10407089: Revert 138212 - Implement High Contrast mode for Chrome OS. (Closed)

Created:
8 years, 7 months ago by Steve Block
Modified:
8 years, 7 months ago
Reviewers:
Zachary Kuznia
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, hashimoto+watch_chromium.org, ben+watch_chromium.org, aboxhall+watch_chromium.org, dhollowa+watch_chromium.org, jonathan.backer, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, Ian Vollick, arv (Not doing code reviews), dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, piman+watch_chromium.org, ctguil+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, zork+watch_chromium.org, jamesr
Visibility:
Public.

Description

Revert 138212 - Implement High Contrast mode for Chrome OS. -Add controller to ash for managing the state of High Contrast mode -Add API to shell to allow Chromium to turn the mode on and off -Add the option to the Chromium OS accessibility settings page. -Add functions to layer.cc/h to enable an inversion filter. This change breaks the build on the Windows canaries after WebKit r117864 due to a change in the the Chromium WebFilterOperation API. See http://build.chromium.org/p/chromium.webkit/builders/Win%20Builder/builds/22082 and https://bugs.webkit.org/show_bug.cgi?id=87046. BUG=chromium-os:30678 Review URL: https://chromiumcodereview.appspot.com/10201014 TBR=zork@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138239

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -130 lines) Patch
M ash/ash.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D ash/high_contrast/high_contrast_controller.h View 1 chunk +0 lines, -36 lines 0 comments Download
D ash/high_contrast/high_contrast_controller.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M ash/shell.h View 3 chunks +0 lines, -7 lines 0 comments Download
M ash/shell.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/chrome_browser_main_extra_parts_ash.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_util.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_util.cc View 3 chunks +0 lines, -16 lines 0 comments Download
M chrome/browser/resources/options2/browser_options.html View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/resources/options2/browser_options.js View 2 chunks +2 lines, -7 lines 0 comments Download
M ui/compositor/layer.h View 2 chunks +0 lines, -5 lines 0 comments Download
M ui/compositor/layer.cc View 4 chunks +2 lines, -15 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Steve Block
8 years, 7 months ago (2012-05-22 09:48:15 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698