Issue 10407084: [Coverity] Fix signed/unsigned issue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10407084: [Coverity] Fix signed/unsigned issue. (Closed)

Created:
8 years, 7 months ago by groby-ooo-7-16

Modified:
8 years, 7 months ago

Reviewers:
cpu_(ooo_6.6-7.5)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Coverity] Fix signed/unsigned issue. NtQueryObject returns, and NT_SUCCESS expects, NTSTATUS (a LONG variable). NT_SUCCESS checks for >=0, so CHECK statements as they are will never fire. CID=104038 BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138286

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	content/common/sandbox_policy.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/10407084/1

8 years, 7 months ago (2012-05-22 02:29:52 UTC) #3

commit-bot: I haz the power

8 years, 7 months ago (2012-05-22 05:04:11 UTC) #4

Try job failure for 10407084-1 (retry) on win_rel for step "sync_unit_tests".
It's a second try, previously, steps "base_unittests, browser_tests,
sync_unit_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Expand Messages | Collapse Messages