Multiple dispatchers for root windows

ui/aura/dispatcher_linux.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_AURA_DISPATCHER_LINUX_H_
 #define UI_AURA_DISPATCHER_LINUX_H_
 #pragma once
 
 #include <map>
+#include <vector>
 #include <X11/Xlib.h>
 // Get rid of a macro from Xlib.h that conflicts with Aura's RootWindow class.
 #undef RootWindow
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/message_loop.h"
 
 namespace aura {
 
 class DispatcherLinux : public MessageLoop::Dispatcher,
                         public base::MessagePumpObserver {
  public:
   DispatcherLinux();
   virtual ~DispatcherLinux();
 
-  void WindowDispatcherCreated(::Window window,
-                               MessageLoop::Dispatcher* dispatcher);
-  void WindowDispatcherDestroying(::Window window);
+  // Register/Unregister Dispatcher for the |window|.
+  void RegisterDispatcher(::Window window,

[Daniel Erat, 2012/05/22 14:33:42]

nit: rename to RegisterWindowDispatcher() or RenderDispatcherForWindow() to make
the difference between this and RegisterRootWindowDispatcher() clearer?

also, mind renaming the |window| param to |x_window|?

[oshima, 2012/05/22 19:50:02]

Agreed. Renamed to RegisterDispatcherFor{Root}Window
Done

+                          MessageLoop::Dispatcher* dispatcher);
+  void UnregisterDispatcher(::Window window);
+
+  // Register/Unregister Dispatchers for RootWindow.

[Daniel Erat, 2012/05/22 14:33:42]

nit: reword this comment to something like:

// Register/unregister Dispatchers to receive all
// events sent to the X root window.

[oshima, 2012/05/22 19:50:02]

Done.

+  void RegisterRootWindowDispatcher(MessageLoop::Dispatcher* dispatcher);
+  void UnregisterRootWindowDispatcher(MessageLoop::Dispatcher* dispatcher);
 
   // Overridden from MessageLoop::Dispatcher:
   virtual bool Dispatch(const base::NativeEvent& event) OVERRIDE;
 
   // Overridden from base::MessagePumpObserver:
   virtual base::EventStatus WillProcessEvent(
       const base::NativeEvent& event) OVERRIDE;
   virtual void DidProcessEvent(const base::NativeEvent& event) OVERRIDE;
 
  private:
   typedef std::map< ::Window, MessageLoop::Dispatcher* > DispatchersMap;
+  typedef std::vector<MessageLoop::Dispatcher*> Dispatchers;
 
   MessageLoop::Dispatcher* GetDispatcherForXEvent(XEvent* xev) const;
+  void DispatchRootWindowEvent(XEvent* xev);
 
   DispatchersMap dispatchers_;
+  Dispatchers root_window_dispatchers_;
+
+  ::Window root_window_;

[Daniel Erat, 2012/05/22 14:33:42]

nit: rename to |x_root_window_|?

[oshima, 2012/05/22 19:50:02]

Done.

 
   DISALLOW_COPY_AND_ASSIGN(DispatcherLinux);
 };
 
 }  // namespace aura
 
 #endif  // UI_AURA_DISPATCHER_LINUX_H_