Multiple dispatchers for root windows

Multiple dispatchers for root windows
This allows ash to inject Dispatcher for root window without
a dispatcher being dependent of aura.

BUG=none
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138451

[Daniel Erat, 2012-05-22 14:33:42]

lgtm

https://chromiumcodereview.appspot.com/10407081/diff/1003/ui/aura/dispatcher_...
File ui/aura/dispatcher_linux.cc (right):

https://chromiumcodereview.appspot.com/10407081/diff/1003/ui/aura/dispatcher_...
ui/aura/dispatcher_linux.cc:67: void
DispatcherLinux::UnregisterDispatcher(::Window window) {
nit: move this after RegisterDispatcher() to match the order from the header

https://chromiumcodereview.appspot.com/10407081/diff/1003/ui/aura/dispatcher_...
ui/aura/dispatcher_linux.cc:127: for (Dispatchers::const_iterator it =
root_window_dispatchers_.begin();
nit: maybe move this into Dispatch() to improve readability?  it's a simple
loop, and there's already a similar loop in Dispatch() for MappingNotify events.

https://chromiumcodereview.appspot.com/10407081/diff/1003/ui/aura/dispatcher_...
File ui/aura/dispatcher_linux.h (right):

https://chromiumcodereview.appspot.com/10407081/diff/1003/ui/aura/dispatcher_...
ui/aura/dispatcher_linux.h:28: void RegisterDispatcher(::Window window,
nit: rename to RegisterWindowDispatcher() or RenderDispatcherForWindow() to make
the difference between this and RegisterRootWindowDispatcher() clearer?

also, mind renaming the |window| param to |x_window|?

https://chromiumcodereview.appspot.com/10407081/diff/1003/ui/aura/dispatcher_...
ui/aura/dispatcher_linux.h:32: // Register/Unregister Dispatchers for
RootWindow.
nit: reword this comment to something like:

// Register/unregister Dispatchers to receive all
// events sent to the X root window.

https://chromiumcodereview.appspot.com/10407081/diff/1003/ui/aura/dispatcher_...
ui/aura/dispatcher_linux.h:54: ::Window root_window_;
nit: rename to |x_root_window_|?

[oshima, 2012-05-22 19:50:02]

https://chromiumcodereview.appspot.com/10407081/diff/1003/ui/aura/dispatcher_...
File ui/aura/dispatcher_linux.cc (right):

https://chromiumcodereview.appspot.com/10407081/diff/1003/ui/aura/dispatcher_...
ui/aura/dispatcher_linux.cc:67: void
DispatcherLinux::UnregisterDispatcher(::Window window) {
On 2012/05/22 14:33:42, Daniel Erat wrote:
> nit: move this after RegisterDispatcher() to match the order from the header

Done.

https://chromiumcodereview.appspot.com/10407081/diff/1003/ui/aura/dispatcher_...
ui/aura/dispatcher_linux.cc:127: for (Dispatchers::const_iterator it =
root_window_dispatchers_.begin();
On 2012/05/22 14:33:42, Daniel Erat wrote:
> nit: maybe move this into Dispatch() to improve readability?  it's a simple
> loop, and there's already a similar loop in Dispatch() for MappingNotify
events.

Done.

https://chromiumcodereview.appspot.com/10407081/diff/1003/ui/aura/dispatcher_...
File ui/aura/dispatcher_linux.h (right):

https://chromiumcodereview.appspot.com/10407081/diff/1003/ui/aura/dispatcher_...
ui/aura/dispatcher_linux.h:28: void RegisterDispatcher(::Window window,
On 2012/05/22 14:33:42, Daniel Erat wrote:
> nit: rename to RegisterWindowDispatcher() or RenderDispatcherForWindow() to
make
> the difference between this and RegisterRootWindowDispatcher() clearer?

Agreed. Renamed to RegisterDispatcherFor{Root}Window

> also, mind renaming the |window| param to |x_window|?

Done

https://chromiumcodereview.appspot.com/10407081/diff/1003/ui/aura/dispatcher_...
ui/aura/dispatcher_linux.h:32: // Register/Unregister Dispatchers for
RootWindow.
On 2012/05/22 14:33:42, Daniel Erat wrote:
> nit: reword this comment to something like:
> 
> // Register/unregister Dispatchers to receive all
> // events sent to the X root window.

Done.

https://chromiumcodereview.appspot.com/10407081/diff/1003/ui/aura/dispatcher_...
ui/aura/dispatcher_linux.h:54: ::Window root_window_;
On 2012/05/22 14:33:42, Daniel Erat wrote:
> nit: rename to |x_root_window_|?

Done.

[oshima, 2012-05-22 19:50:51]

ben -> OWNERS review

[Ben Goodger (Google), 2012-05-22 23:44:40]

lgtm

https://chromiumcodereview.appspot.com/10407081/diff/4/ui/aura/dispatcher_lin...
File ui/aura/dispatcher_linux.h (right):

https://chromiumcodereview.appspot.com/10407081/diff/4/ui/aura/dispatcher_lin...
ui/aura/dispatcher_linux.h:28: void
RegisterDispatcherForWindow(MessageLoop::Dispatcher* dispatcher,
AddDispatcher

https://chromiumcodereview.appspot.com/10407081/diff/4/ui/aura/dispatcher_lin...
ui/aura/dispatcher_linux.h:30: void UnregisterDispatcherForWindow(::Window
x_window);
RemoveDispatcher

https://chromiumcodereview.appspot.com/10407081/diff/4/ui/aura/dispatcher_lin...
ui/aura/dispatcher_linux.h:33: // root wnidow.
window.

https://chromiumcodereview.appspot.com/10407081/diff/4/ui/aura/dispatcher_lin...
ui/aura/dispatcher_linux.h:35: void
UnregisterDispatcherForRootWindow(MessageLoop::Dispatcher* dispatcher);
etc

[oshima, 2012-05-23 00:31:06]

https://chromiumcodereview.appspot.com/10407081/diff/4/ui/aura/dispatcher_lin...
File ui/aura/dispatcher_linux.h (right):

https://chromiumcodereview.appspot.com/10407081/diff/4/ui/aura/dispatcher_lin...
ui/aura/dispatcher_linux.h:28: void
RegisterDispatcherForWindow(MessageLoop::Dispatcher* dispatcher,
On 2012/05/22 23:44:40, Ben Goodger (Google) wrote:
> AddDispatcher

Done.

https://chromiumcodereview.appspot.com/10407081/diff/4/ui/aura/dispatcher_lin...
ui/aura/dispatcher_linux.h:30: void UnregisterDispatcherForWindow(::Window
x_window);
On 2012/05/22 23:44:40, Ben Goodger (Google) wrote:
> RemoveDispatcher

Done.

https://chromiumcodereview.appspot.com/10407081/diff/4/ui/aura/dispatcher_lin...
ui/aura/dispatcher_linux.h:33: // root wnidow.
On 2012/05/22 23:44:40, Ben Goodger (Google) wrote:
> window.

Done.

https://chromiumcodereview.appspot.com/10407081/diff/4/ui/aura/dispatcher_lin...
ui/aura/dispatcher_linux.h:35: void
UnregisterDispatcherForRootWindow(MessageLoop::Dispatcher* dispatcher);
On 2012/05/22 23:44:40, Ben Goodger (Google) wrote:
> etc

Done.

[commit-bot: I haz the power, 2012-05-23 00:31:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/10407081/5010

[commit-bot: I haz the power, 2012-05-23 04:12:29]

Try job failure for 10407081-5010 (retry) on win_rel for step "sync_unit_tests".
It's a second try, previously, step "sync_unit_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-05-23 07:25:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/10407081/5010