chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm - Issue 10407075: Fix transparent crack at top of page while resizing devtools NSSplitView divider.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

Issue 10407075: Fix transparent crack at top of page while resizing devtools NSSplitView divider. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix test crash Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

index ba04ffde0d70c78357bf363cd614e92562b049f3..a328e3dc51170980de597a366b7ff0c20aeba43f 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

@@ -312,6 +312,9 @@ void RecordAppLaunch(Profile* profile, GURL url) {

}

- (void)dealloc {

+ // Clear delegate so it doesn't get called during stopAnimation.

+ [[self animatableView] setResizeDelegate:nil];

// We better stop any in-flight animation if we're being killed.

[[self animatableView] stopAnimation];

« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/dev_tools_controller.mm » ('j') | chrome/browser/ui/cocoa/dev_tools_controller.mm » ('J')