Fix transparent crack at top of page while resizing devtools NSSplitView divider.

Fix transparent crack at top of page while resizing devtools NSSplitView divider.

BUG=127652
TEST=Open devtools on http://www.webkit.org/blog-files/3d-transforms/poster-circle.html; resize divider bar; verify no transparent crack at top of page.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138325

[jbates, 2012-05-21 21:39:43]

thakis: ptal

[jbates, 2012-05-21 21:41:52]

https://chromiumcodereview.appspot.com/10407075/diff/2001/chrome/browser/ui/c...
File chrome/browser/ui/cocoa/dev_tools_controller.mm (right):

https://chromiumcodereview.appspot.com/10407075/diff/2001/chrome/browser/ui/c...
chrome/browser/ui/cocoa/dev_tools_controller.mm:215: -
(BOOL)splitView:(NSSplitView *)splitView
Note: this appears to have been dead code since 2010-11-16, because
DevToolsController was not set as the NSSplitView delegate before this CL.

[Nico, 2012-05-21 21:57:15]

lgtm

[jbates, 2012-05-21 22:06:07]

sky: chrome/browser/ui/OWNERS
alekseys: fyi (I think your 2010 splitView:shouldAdjustSizeOfSubview code goes
live with this CL)

[sky, 2012-05-21 22:37:02]

LGTM

[commit-bot: I haz the power, 2012-05-21 22:45:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jbates@chromium.org/10407075/2001

[commit-bot: I haz the power, 2012-05-21 23:26:05]

Try job failure for 10407075-2001 (retry) on mac_rel for step "unit_tests".
It's a second try, previously, step "unit_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[jbates, 2012-05-22 01:35:27]

PTAL: had to remove the delegate to prevent calls back into the
BrowserWindowController during dealloc.

[Nico, 2012-05-22 02:38:39]

https://chromiumcodereview.appspot.com/10407075/diff/7002/chrome/browser/ui/c...
File chrome/browser/ui/cocoa/dev_tools_controller.mm (right):

https://chromiumcodereview.appspot.com/10407075/diff/7002/chrome/browser/ui/c...
chrome/browser/ui/cocoa/dev_tools_controller.mm:67: }
You should probably clear out splitView_'s delegate in [DevToolsController
dealloc] too.

[jbates, 2012-05-22 17:46:25]

https://chromiumcodereview.appspot.com/10407075/diff/7002/chrome/browser/ui/c...
File chrome/browser/ui/cocoa/dev_tools_controller.mm (right):

https://chromiumcodereview.appspot.com/10407075/diff/7002/chrome/browser/ui/c...
chrome/browser/ui/cocoa/dev_tools_controller.mm:67: }
On 2012/05/22 02:38:39, Nico wrote:
> You should probably clear out splitView_'s delegate in [DevToolsController
> dealloc] too.

Done.

[Nico, 2012-05-22 17:47:17]

lgtm

[commit-bot: I haz the power, 2012-05-22 17:54:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jbates@chromium.org/10407075/6