Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Side by Side Diff: chrome/browser/resources/options2/chromeos/network_list.js

Issue 10407069: Fixed enable/disable handling for WiMAX. Removed Cellular section when not available. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixes Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('options.network', function() { 5 cr.define('options.network', function() {
6 6
7 var ArrayDataModel = cr.ui.ArrayDataModel; 7 var ArrayDataModel = cr.ui.ArrayDataModel;
8 var List = cr.ui.List; 8 var List = cr.ui.List;
9 var ListItem = cr.ui.ListItem; 9 var ListItem = cr.ui.ListItem;
10 var Menu = cr.ui.Menu; 10 var Menu = cr.ui.Menu;
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 var cellularAvailable_ = false; 70 var cellularAvailable_ = false;
71 71
72 /** 72 /**
73 * Indicates if cellular networks are enabled. 73 * Indicates if cellular networks are enabled.
74 * @type {boolean} 74 * @type {boolean}
75 * @private 75 * @private
76 */ 76 */
77 var cellularEnabled_ = false; 77 var cellularEnabled_ = false;
78 78
79 /** 79 /**
80 * Indicates if WiMAX networks are available.
81 * @type {boolean}
82 * @private
83 */
84 var wimaxAvailable_ = false;
85
86 /**
87 * Indicates if WiMAX networks are enabled.
88 * @type {boolean}
89 * @private
90 */
91 var wimaxEnabled_ = false;
92
93 /**
80 * Indicates if mobile data roaming is enabled. 94 * Indicates if mobile data roaming is enabled.
81 * @type {boolean} 95 * @type {boolean}
82 * @private 96 * @private
83 */ 97 */
84 var enableDataRoaming_ = false; 98 var enableDataRoaming_ = false;
85 99
86 /** 100 /**
87 * Create an element in the network list for controlling network 101 * Create an element in the network list for controlling network
88 * connectivity. 102 * connectivity.
89 * @param {Object} data Description of the network list or command. 103 * @param {Object} data Description of the network list or command.
(...skipping 420 matching lines...) Expand 10 before | Expand all | Expand 10 after
510 if (this.data_.key == 'wifi') { 524 if (this.data_.key == 'wifi') {
511 addendum.push({label: loadTimeData.getString('turnOffWifi'), 525 addendum.push({label: loadTimeData.getString('turnOffWifi'),
512 command: function() { 526 command: function() {
513 chrome.send('disableWifi'); 527 chrome.send('disableWifi');
514 }, 528 },
515 data: {}}); 529 data: {}});
516 } else if (this.data_.key == 'wimax') { 530 } else if (this.data_.key == 'wimax') {
517 // TODO(zelidrag): Add proper strings for wimax. 531 // TODO(zelidrag): Add proper strings for wimax.
518 addendum.push({label: loadTimeData.getString('turnOffCellular'), 532 addendum.push({label: loadTimeData.getString('turnOffCellular'),
519 command: function() { 533 command: function() {
520 chrome.send('disableCellular'); 534 chrome.send('disableWimax');
521 }, 535 },
522 data: {}}); 536 data: {}});
523 } else if (this.data_.key == 'cellular') { 537 } else if (this.data_.key == 'cellular') {
524 addendum.push({label: loadTimeData.getString('turnOffCellular'), 538 addendum.push({label: loadTimeData.getString('turnOffCellular'),
525 command: function() { 539 command: function() {
526 chrome.send('disableCellular'); 540 chrome.send('disableCellular');
527 }, 541 },
528 data: {}}); 542 data: {}});
529 } 543 }
530 } 544 }
(...skipping 292 matching lines...) Expand 10 before | Expand all | Expand 10 after
823 837
824 /** 838 /**
825 * Chrome callback for updating network controls. 839 * Chrome callback for updating network controls.
826 * @param {Object} data Description of available network devices and their 840 * @param {Object} data Description of available network devices and their
827 * corresponding state. 841 * corresponding state.
828 */ 842 */
829 NetworkList.refreshNetworkData = function(data) { 843 NetworkList.refreshNetworkData = function(data) {
830 var networkList = $('network-list'); 844 var networkList = $('network-list');
831 cellularAvailable_ = data.cellularAvailable; 845 cellularAvailable_ = data.cellularAvailable;
832 cellularEnabled_ = data.cellularEnabled; 846 cellularEnabled_ = data.cellularEnabled;
847 wimaxAvailable_ = data.wimaxAvailable;
848 wimaxEnabled_ = data.wimaxEnabled;
833 849
834 if (data.accessLocked) { 850 if (data.accessLocked) {
835 $('network-locked-message').hidden = false; 851 $('network-locked-message').hidden = false;
836 networkList.disabled = true; 852 networkList.disabled = true;
837 $('use-shared-proxies').disabled = true; 853 $('use-shared-proxies').disabled = true;
838 } else { 854 } else {
839 $('network-locked-message').hidden = true; 855 $('network-locked-message').hidden = true;
840 networkList.disabled = false; 856 networkList.disabled = false;
841 $('use-shared-proxies').disabled = false; 857 $('use-shared-proxies').disabled = false;
842 } 858 }
(...skipping 24 matching lines...) Expand all
867 networkList.update({key: 'wifi', 883 networkList.update({key: 'wifi',
868 subtitle: loadTimeData.getString('networkDisabled'), 884 subtitle: loadTimeData.getString('networkDisabled'),
869 iconType: 'wifi', 885 iconType: 'wifi',
870 command: enableWifi}); 886 command: enableWifi});
871 } 887 }
872 888
873 // Only show cellular control if available and not in airplane mode. 889 // Only show cellular control if available and not in airplane mode.
874 if (data.cellularAvailable && !data.airplaneMode) { 890 if (data.cellularAvailable && !data.airplaneMode) {
875 if (data.cellularEnabled) { 891 if (data.cellularEnabled) {
876 loadData_('cellular', data.wirelessList, data.rememberedList); 892 loadData_('cellular', data.wirelessList, data.rememberedList);
877 loadData_('wimax', data.wirelessList, data.rememberedList);
878 } else { 893 } else {
879 var subtitle = loadTimeData.getString('networkDisabled'); 894 var subtitle = loadTimeData.getString('networkDisabled');
880 var enableCellular = function() { 895 var enableCellular = function() {
881 chrome.send('enableCellular'); 896 chrome.send('enableCellular');
882 }; 897 };
883 networkList.update({key: 'cellular', 898 networkList.update({key: 'cellular',
884 subtitle: subtitle, 899 subtitle: subtitle,
885 iconType: 'cellular', 900 iconType: 'cellular',
886 command: enableCellular}); 901 command: enableCellular});
887 } 902 }
888 } else { 903 } else {
889 networkList.deleteItem('cellular'); 904 networkList.deleteItem('cellular');
890 } 905 }
891 906
907 // Only show cellular control if available and not in airplane mode.
908 if (data.wimaxAvailable && !data.airplaneMode) {
909 if (data.wimaxEnabled) {
910 loadData_('wimax', data.wirelessList, data.rememberedList);
911 } else {
912 var subtitle = loadTimeData.getString('networkDisabled');
913 var enableWimax = function() {
914 chrome.send('enableWimax');
915 };
916 networkList.update({key: 'wimax',
917 subtitle: subtitle,
918 iconType: 'cellular',
919 command: enableWimax});
920 }
921 } else {
922 networkList.deleteItem('wimax');
923 }
924
892 // Only show VPN control if there is an available network and an internet 925 // Only show VPN control if there is an available network and an internet
893 // connection. 926 // connection.
894 if (data.vpnList.length > 0 && (ethernetConnection || 927 if (data.vpnList.length > 0 && (ethernetConnection ||
895 isConnected_(data.wirelessList))) 928 isConnected_(data.wirelessList)))
896 loadData_('vpn', data.vpnList, data.rememberedList); 929 loadData_('vpn', data.vpnList, data.rememberedList);
897 else 930 else
898 networkList.deleteItem('vpn'); 931 networkList.deleteItem('vpn');
899 networkList.updateToggleControl('airplaneMode', data.airplaneMode); 932 networkList.updateToggleControl('airplaneMode', data.airplaneMode);
900 }; 933 };
901 934
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
1013 * Whether the Network list is disabled. Only used for display purpose. 1046 * Whether the Network list is disabled. Only used for display purpose.
1014 * @type {boolean} 1047 * @type {boolean}
1015 */ 1048 */
1016 cr.defineProperty(NetworkList, 'disabled', cr.PropertyKind.BOOL_ATTR); 1049 cr.defineProperty(NetworkList, 'disabled', cr.PropertyKind.BOOL_ATTR);
1017 1050
1018 // Export 1051 // Export
1019 return { 1052 return {
1020 NetworkList: NetworkList 1053 NetworkList: NetworkList
1021 }; 1054 };
1022 }); 1055 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698