Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Side by Side Diff: chrome/browser/ui/webui/session_favicon_source.cc

Issue 10407066: NTP: Prevent tab sync icons from being cached. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments. Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/webui/session_favicon_source.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/session_favicon_source.h" 5 #include "chrome/browser/ui/webui/session_favicon_source.h"
6 6
7 #include "chrome/browser/sync/glue/session_model_associator.h" 7 #include "chrome/browser/sync/glue/session_model_associator.h"
8 #include "chrome/browser/sync/profile_sync_service_factory.h" 8 #include "chrome/browser/sync/profile_sync_service_factory.h"
9 #include "chrome/browser/sync/profile_sync_service.h" 9 #include "chrome/browser/sync/profile_sync_service.h"
10 #include "chrome/common/url_constants.h" 10 #include "chrome/common/url_constants.h"
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 42
43 std::string SessionFaviconSource::GetMimeType(const std::string&) const { 43 std::string SessionFaviconSource::GetMimeType(const std::string&) const {
44 return "image/png"; 44 return "image/png";
45 } 45 }
46 46
47 bool SessionFaviconSource::ShouldReplaceExistingSource() const { 47 bool SessionFaviconSource::ShouldReplaceExistingSource() const {
48 // Leave the existing DataSource in place, otherwise we'll drop any pending 48 // Leave the existing DataSource in place, otherwise we'll drop any pending
49 // requests on the floor. 49 // requests on the floor.
50 return false; 50 return false;
51 } 51 }
52
53 bool SessionFaviconSource::AllowCaching() const {
54 // Prevent responses from being cached, otherwise session favicons won't
55 // update in a timely manner.
56 return false;
57 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/session_favicon_source.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698