Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1286)

Issue 10407060: RefCounted types should not have public destructors, net/ redux (Closed)

Created:
8 years, 7 months ago by Ryan Sleevi
Modified:
8 years, 6 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

RefCounted types should not have public destructors, net/ redux BUG=123295 TEST=it compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=139263

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -18 lines) Patch
M net/proxy/dhcp_proxy_script_fetcher.cc View 1 chunk +7 lines, -12 lines 0 comments Download
M net/proxy/proxy_script_decider_unittest.cc View 4 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Ryan Sleevi
eroman: Hopefully an easy stamp for you? Separated out from the rest of the net/ ...
8 years, 7 months ago (2012-05-21 08:06:20 UTC) #1
eroman
lgtm
8 years, 7 months ago (2012-05-21 19:29:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10407060/1
8 years, 7 months ago (2012-05-21 19:31:43 UTC) #3
commit-bot: I haz the power
Try job failure for 10407060-1 on win for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=12433 Step "update" is always ...
8 years, 7 months ago (2012-05-21 19:59:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10407060/1
8 years, 7 months ago (2012-05-21 22:18:34 UTC) #5
commit-bot: I haz the power
Try job failure for 10407060-1 (retry) (retry) on win_rel for steps "base_unittests, sync_unit_tests". It's a ...
8 years, 7 months ago (2012-05-22 02:52:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10407060/1
8 years, 6 months ago (2012-05-28 20:58:33 UTC) #7
commit-bot: I haz the power
8 years, 6 months ago (2012-05-28 22:19:08 UTC) #8
Change committed as 139263

Powered by Google App Engine
This is Rietveld 408576698