Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: build/common.gypi

Issue 10407058: Compile in Breakpad by default on Linux (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add #ifdef to chrome/browser/chromeos/login/wizard_controller.cc too Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chrome_browser_main_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index ab366bd35113e4e6eb2765896ba0351198d9d9ad..024b6e475d0f2c60977c9ecd6afe7029efa5b26f 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -853,9 +853,9 @@
# Enable strict glibc debug mode.
'glibcxx_debug%': 0,
-
- # Override whether we should use Breakpad on Linux. I.e. for Chrome bot.
- 'linux_breakpad%': 0,
+ # Compile in Breakpad support by default so that it can be tested,
+ # even if it not enabled by default at runtime.
+ 'linux_breakpad%': 1,
# And if we want to dump symbols for Breakpad-enabled builds.
'linux_dump_symbols%': 0,
# And if we want to strip the binary after dumping symbols.
@@ -1018,9 +1018,6 @@
}, {
'gcc_version%': 0,
}],
- ['branding=="Chrome"', {
- 'linux_breakpad%': 1,
- }],
# All Chrome builds have breakpad symbols, but only process the
# symbols from official builds.
['(branding=="Chrome" and buildtype=="Official")', {
@@ -2799,8 +2796,10 @@
],
}],
['linux_breakpad==1', {
- 'cflags': [ '-g' ],
'defines': ['USE_LINUX_BREAKPAD'],
+ }],
+ ['linux_dump_symbols==1', {
+ 'cflags': [ '-g' ],
'conditions': [
['target_arch=="ia32"', {
'target_conditions': [
« no previous file with comments | « no previous file | chrome/browser/chrome_browser_main_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698