Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3670)

Unified Diff: chrome/browser/extensions/extension_window_controller.h

Issue 10407035: Extension/Platform App window isolation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add "ForFunction" Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_window_controller.h
diff --git a/chrome/browser/extensions/extension_window_controller.h b/chrome/browser/extensions/extension_window_controller.h
index 06db3c5b022fa620645c7a9fac02bd3288e826f0..24ef799938585316c1e55edd4392398f63841c28 100644
--- a/chrome/browser/extensions/extension_window_controller.h
+++ b/chrome/browser/extensions/extension_window_controller.h
@@ -21,6 +21,10 @@ namespace base {
class DictionaryValue;
}
+namespace extensions {
+class Extension;
+}
+
namespace gfx {
class Rect;
}
@@ -34,11 +38,6 @@ class ExtensionWindowController {
REASON_NOT_EDITABLE,
};
- enum ProfileMatchType {
- MATCH_NORMAL_ONLY,
- MATCH_INCOGNITO
- };
-
ExtensionWindowController(BaseWindow* window, Profile* profile);
virtual ~ExtensionWindowController();
@@ -46,9 +45,6 @@ class ExtensionWindowController {
Profile* profile() const { return profile_; }
- // Returns true if the window matches the profile.
- bool MatchesProfile(Profile* profile, ProfileMatchType match_type) const;
-
// Return an id uniquely identifying the window.
virtual int GetWindowId() const = 0;
@@ -76,6 +72,11 @@ class ExtensionWindowController {
// TODO(stevenjb): Temporary workaround. Eliminate this.
virtual Browser* GetBrowser() const;
+ // Extension/window visibility and ownership is window-specific, subclasses
+ // need to define this behavior.
+ virtual bool IsVisibleToExtension(
+ const extensions::Extension* extension) const = 0;
+
private:
BaseWindow* window_;
Profile* profile_;
« no previous file with comments | « chrome/browser/extensions/extension_tabs_module.cc ('k') | chrome/browser/extensions/extension_window_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698