Picked up from stevenjb@: Added WimaxConfigView.

Picked up stevenjb@: Added WimaxConfigView.

BUG=128429
TEST=Run chrome ash/chromeos in a stub environment. It should be possible to 'connect' to 'Fake Wimax1'


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137892

[oshima, 2012-05-18 01:03:15]

https://chromiumcodereview.appspot.com/10407034/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/network_message_observer.cc (right):

https://chromiumcodereview.appspot.com/10407034/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/network_message_observer.cc:176: it !=
cros->wimax_networks().end(); it++) {
++i

https://chromiumcodereview.appspot.com/10407034/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/options/wimax_config_view.cc (right):

https://chromiumcodereview.appspot.com/10407034/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/options/wimax_config_view.cc:70: &&
passphrase_textfield_->text().length() < kMinWimaxPasswordLen)
move && to previous line
can this simply be

return passphrase_textfield_ && passphrase_textfield_->text().length() >=
kMinWimaxPassswordLen;

?

https://chromiumcodereview.appspot.com/10407034/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/options/wimax_config_view.cc:96: if (error_msg.empty()
&& !service_path_.empty()) {
isn't error_msg always empty?

https://chromiumcodereview.appspot.com/10407034/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/options/wimax_config_view.cc:129: const string16&
new_contents) {
indent

https://chromiumcodereview.appspot.com/10407034/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/options/wimax_config_view.cc:134: const views::KeyEvent&
key_event) {
indent

https://chromiumcodereview.appspot.com/10407034/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/options/wimax_config_view.cc:166: bool share_default =
(wimax->profile_type() != PROFILE_USER);
nit: no need for ().

https://chromiumcodereview.appspot.com/10407034/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/options/wimax_config_view.cc:187: return result;
this one is up to you. can be just

return passphrase_textfield_ ? UTF16ToUTF8(passphrase_textfield_->text() :
std::string();

https://chromiumcodereview.appspot.com/10407034/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/options/wimax_config_view.cc:193: return
save_credentials_checkbox_->checked();
ditto

https://chromiumcodereview.appspot.com/10407034/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/options/wimax_config_view.cc:199: return
share_network_checkbox_->checked();
ditto

[zel, 2012-05-18 01:17:40]

https://chromiumcodereview.appspot.com/10407034/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/network_message_observer.cc (right):

https://chromiumcodereview.appspot.com/10407034/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/network_message_observer.cc:176: it !=
cros->wimax_networks().end(); it++) {
On 2012/05/18 01:03:15, oshima wrote:
> ++i

Done.

https://chromiumcodereview.appspot.com/10407034/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/options/wimax_config_view.cc (right):

https://chromiumcodereview.appspot.com/10407034/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/options/wimax_config_view.cc:66: static const size_t
kMinWimaxPasswordLen = 0;
Ben, if there are limit on WiMAX password side at all? The code right now does
not have it.

https://chromiumcodereview.appspot.com/10407034/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/options/wimax_config_view.cc:70: &&
passphrase_textfield_->text().length() < kMinWimaxPasswordLen)
On 2012/05/18 01:03:15, oshima wrote:
> move && to previous line
> can this simply be
> 
> return passphrase_textfield_ && passphrase_textfield_->text().length() >=
> kMinWimaxPassswordLen;
> 
> ?

Done.

https://chromiumcodereview.appspot.com/10407034/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/options/wimax_config_view.cc:96: if (error_msg.empty()
&& !service_path_.empty()) {
On 2012/05/18 01:03:15, oshima wrote:
> isn't error_msg always empty?

Done.

https://chromiumcodereview.appspot.com/10407034/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/options/wimax_config_view.cc:129: const string16&
new_contents) {
On 2012/05/18 01:03:15, oshima wrote:
> indent

Done.

https://chromiumcodereview.appspot.com/10407034/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/options/wimax_config_view.cc:134: const views::KeyEvent&
key_event) {
On 2012/05/18 01:03:15, oshima wrote:
> indent

Done.

https://chromiumcodereview.appspot.com/10407034/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/options/wimax_config_view.cc:166: bool share_default =
(wimax->profile_type() != PROFILE_USER);
On 2012/05/18 01:03:15, oshima wrote:
> nit: no need for ().

I like () for bool expressions.

https://chromiumcodereview.appspot.com/10407034/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/options/wimax_config_view.cc:187: return result;
On 2012/05/18 01:03:15, oshima wrote:
> this one is up to you. can be just
> 
> return passphrase_textfield_ ? UTF16ToUTF8(passphrase_textfield_->text() :
> std::string();
> 

Done.

https://chromiumcodereview.appspot.com/10407034/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/options/wimax_config_view.cc:193: return
save_credentials_checkbox_->checked();
On 2012/05/18 01:03:15, oshima wrote:
> ditto

Done.

https://chromiumcodereview.appspot.com/10407034/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/options/wimax_config_view.cc:199: return
share_network_checkbox_->checked();
On 2012/05/18 01:03:15, oshima wrote:
> ditto

Done.

[Ben Chan, 2012-05-18 01:25:42]

https://chromiumcodereview.appspot.com/10407034/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/options/wimax_config_view.cc (right):

https://chromiumcodereview.appspot.com/10407034/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/options/wimax_config_view.cc:66: static const size_t
kMinWimaxPasswordLen = 0;
I don't see any information about the minimum password length.

On 2012/05/18 01:17:41, zel wrote:
> Ben, if there are limit on WiMAX password side at all? The code right now does
> not have it.

[zel, 2012-05-18 01:27:22]

https://chromiumcodereview.appspot.com/10407034/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/options/wimax_config_view.cc (right):

https://chromiumcodereview.appspot.com/10407034/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/options/wimax_config_view.cc:66: static const size_t
kMinWimaxPasswordLen = 0;
On 2012/05/18 01:25:42, Ben Chan wrote:
> I don't see any information about the minimum password length.
> 
> On 2012/05/18 01:17:41, zel wrote:
> > Ben, if there are limit on WiMAX password side at all? The code right now
does
> > not have it.
> 

So, zero it is until you tell us otherwise.

[oshima, 2012-05-18 01:39:13]

LGTM

https://chromiumcodereview.appspot.com/10407034/diff/3001/chrome/browser/chro...
File chrome/browser/chromeos/cros/network_library_impl_stub.cc (right):

https://chromiumcodereview.appspot.com/10407034/diff/3001/chrome/browser/chro...
chrome/browser/chromeos/cros/network_library_impl_stub.cc:399: if
(passphrase.find("bad") == 0) {
!passphrase.find("bad")

https://chromiumcodereview.appspot.com/10407034/diff/3001/chrome/browser/chro...
chrome/browser/chromeos/cros/network_library_impl_stub.cc:402: } else if
(passphrase.find("error") == 0) {
ditto

[commit-bot: I haz the power, 2012-05-18 01:45:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zelidrag@chromium.org/10407034/3001

[commit-bot: I haz the power, 2012-05-18 03:06:45]

Change committed as 137809