Address a few TODOs related to type propagation.

runtime/vm/intermediate_language.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/intermediate_language.h"
 
 #include "vm/bit_vector.h"
 #include "vm/object.h"
 #include "vm/os.h"
 #include "vm/scopes.h"
@@ skipping 322 matching lines @@
   const AbstractType& function_type =
       AbstractType::Handle(ArgumentAt(0)->StaticType());
   if (function_type.IsDynamicType() || function_type.IsFunctionInterface()) {
     // The function type is not statically known or simply Function.
     return Type::DynamicType();
   }
   const Class& signature_class = Class::Handle(function_type.type_class());
   ASSERT(signature_class.IsSignatureClass());
   const Function& signature_function =
       Function::Handle(signature_class.signature_function());
-  // TODO(regis): The result type may be generic.
+  // TODO(regis): The result type may be generic. Consider upper bounds.
   return signature_function.result_type();
 }
 
 
 RawAbstractType* InstanceCallComp::StaticType() const {
   return Type::DynamicType();
 }
 
 
 RawAbstractType* StaticCallComp::StaticType() const {
@@ skipping 22 matching lines @@
 }
 
 
 RawAbstractType* EqualityCompareComp::StaticType() const {
   return Type::BoolInterface();
 }
 
 
 RawAbstractType* NativeCallComp::StaticType() const {
   // The result type of the native function is identical to the result type of
-  // the enclosing native Dart function.
-  // TODO(regis): Can we trust it or should we check anyway? Check for now.
+  // the enclosing native Dart function. However, we prefer to check the type
+  // of the value returned from the native call.
   return Type::DynamicType();
 }
 
 
 RawAbstractType* StoreIndexedComp::StaticType() const {
   return value()->StaticType();
 }
 
 
 RawAbstractType* InstanceSetterComp::StaticType() const {
-  // TODO(regis): Would it be correct to return value()->StaticType()?
-  return Type::DynamicType();
+  return value()->StaticType();
 }
 
 
 RawAbstractType* StaticSetterComp::StaticType() const {
-  // TODO(regis): Would it be correct/better to return value()->StaticType()?
-  return setter_function().result_type();
+  const AbstractType& assigned_value_type =
+      AbstractType::Handle(value()->StaticType());
+  if (assigned_value_type.IsDynamicType()) {
+    // Static type of assigned value is unknown, return static type of setter
+    // value parameter.
+    return setter_function().ParameterTypeAt(0);
+  }
+  return assigned_value_type.raw();
 }
 
 
 RawAbstractType* LoadInstanceFieldComp::StaticType() const {
   return field().type();
 }
 
 
 RawAbstractType* StoreInstanceFieldComp::StaticType() const {
   const AbstractType& assigned_value_type =
@@ skipping 34 matching lines @@
 
 RawAbstractType* CreateArrayComp::StaticType() const {
   UNREACHABLE();
   return AbstractType::null();
 }
 
 
 RawAbstractType* CreateClosureComp::StaticType() const {
   const Function& fun = function();
   const Class& signature_class = Class::Handle(fun.signature_class());
-  // TODO(regis): Can we take (constant) type_arguments() into consideration?
+  // TODO(regis): The signature type may be generic. Consider upper bounds.
   // For now, we return Dynamic (no type test elimination) if the signature
   // class is parameterized, or a non-parameterized finalized type otherwise.
   if (signature_class.HasTypeArguments()) {
     return Type::DynamicType();
   }
   // Make sure we use the canonical signature class.
   const Type& type = Type::Handle(signature_class.SignatureType());
   const Class& canonical_signature_class = Class::Handle(type.type_class());
   return Type::NewNonParameterizedType(canonical_signature_class);
 }
@@ skipping 11 matching lines @@
 }
 
 
 RawAbstractType* NativeLoadFieldComp::StaticType() const {
   ASSERT(!type().IsNull());
   return type().raw();
 }
 
 
 RawAbstractType* NativeStoreFieldComp::StaticType() const {
-  return value()->StaticType();
+  ASSERT(!type().IsNull());
+  const AbstractType& assigned_value_type =
+      AbstractType::Handle(value()->StaticType());
+  if (assigned_value_type.IsDynamicType()) {
+    // Static type of assigned value is unknown, return static type of field.
+    return type().raw();
+  }
+  return assigned_value_type.raw();
 }
 
 
 RawAbstractType* InstantiateTypeArgumentsComp::StaticType() const {
   UNREACHABLE();
   return AbstractType::null();
 }
 
 
 RawAbstractType* ExtractConstructorTypeArgumentsComp::StaticType() const {
@@ skipping 26 matching lines @@
 }
 
 
 RawAbstractType* CatchEntryComp::StaticType() const {
   UNREACHABLE();
   return AbstractType::null();
 }
 
 
 }  // namespace dart